Skip to content

Delete ShadowConcreteUnboxingThunkNode #122469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbomer merged 1 commit into from
Dec 12, 2025
Merged

Delete ShadowConcreteUnboxingThunkNode #122469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/NodeFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,12 +410,6 @@ private void CreateNodeCaches()

_shadowConcreteMethods = new ShadowConcreteMethodHashtable(this);

_shadowConcreteUnboxingMethods = new NodeCache<MethodDesc, ShadowConcreteUnboxingThunkNode>(method =>
{
MethodDesc canonMethod = method.GetCanonMethodTarget(CanonicalFormKind.Specific);
return new ShadowConcreteUnboxingThunkNode(method, MethodEntrypoint(canonMethod, true));
});

_virtMethods = new VirtualMethodUseHashtable(this);

_variantMethods = new NodeCache<MethodDesc, VariantInterfaceMethodUseNode>((MethodDesc method) =>
Expand Down Expand Up @@ -1159,13 +1153,14 @@ public IMethodNode ExactCallableAddressTakenAddress(MethodDesc method, bool isUn
return AddressTakenMethodEntrypoint(method, isUnboxingStub);
}

public IMethodNode CanonicalEntrypoint(MethodDesc method, bool isUnboxingStub = false)
public IMethodNode CanonicalEntrypoint(MethodDesc method)
{
MethodDesc canonMethod = method.GetCanonMethodTarget(CanonicalFormKind.Specific);
if (method != canonMethod)
return ShadowConcreteMethod(method, isUnboxingStub);
if (method != canonMethod) {
return ShadowConcreteMethod(method);
}
else
return MethodEntrypoint(method, isUnboxingStub);
return MethodEntrypoint(method);
}

private NodeCache<MethodDesc, GVMDependenciesNode> _gvmDependenciesNode;
Expand Down Expand Up @@ -1284,13 +1279,9 @@ protected override ShadowConcreteMethodNode CreateValueFromKey(MethodDesc key) =
}

private ShadowConcreteMethodHashtable _shadowConcreteMethods;
private NodeCache<MethodDesc, ShadowConcreteUnboxingThunkNode> _shadowConcreteUnboxingMethods;
public IMethodNode ShadowConcreteMethod(MethodDesc method, bool isUnboxingStub = false)
public IMethodNode ShadowConcreteMethod(MethodDesc method)
{
if (isUnboxingStub)
return _shadowConcreteUnboxingMethods.GetOrAdd(method);
else
return _shadowConcreteMethods.GetOrCreateValue(method);
return _shadowConcreteMethods.GetOrCreateValue(method);
}

private static readonly string[][] s_helperEntrypointNames = new string[][] {
Expand Down
83 changes: 0 additions & 83 deletions ...ls/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ShadowConcreteUnboxingThunkNode.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/coreclr/tools/aot/ILCompiler.Compiler/ILCompiler.Compiler.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,6 @@
<Compile Include="Compiler\DependencyAnalysis\ModuleMetadataNode.cs" />
<Compile Include="Compiler\DependencyAnalysis\TypeMetadataNode.cs" />
<Compile Include="Compiler\DependencyAnalysis\ScannedMethodNode.cs" />
<Compile Include="Compiler\DependencyAnalysis\ShadowConcreteUnboxingThunkNode.cs" />
<Compile Include="Compiler\ILScanner.cs" />
<Compile Include="Compiler\ILScannerBuilder.cs" />
<Compile Include="Compiler\LibraryInitializers.cs" />
Expand Down
Loading