Delete ShadowConcreteUnboxingThunkNode #122469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
added
the
NO-MERGE
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes dead code related to unboxing thunk support for concrete generic methods. The ShadowConcreteUnboxingThunkNode class and its infrastructure were never actually used, as verified by checking all call sites of CanonicalEntrypoint and ShadowConcreteMethod.
Key changes:
- Deleted the entire
ShadowConcreteUnboxingThunkNode.csfile - Removed the
isUnboxingStubparameter fromCanonicalEntrypointandShadowConcreteMethodmethods - Removed the
_shadowConcreteUnboxingMethodscache and its initialization code
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ShadowConcreteUnboxingThunkNode.cs | Deleted - entire class removed as dead code |
| NodeFactory.cs | Simplified CanonicalEntrypoint and ShadowConcreteMethod methods by removing unused isUnboxingStub parameter; removed unused cache field |
sbomer
force-pushed
the
rmShadowThunk
branch
from
118e368 to
89ca33d
Compare
This was referenced Dec 12, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like dead code if I didn't miss anything. I only see
CanonicalEntrypointcalled with a single argument.