Skip to content

Conversation

@agocke
Copy link
Member

@agocke agocke commented Dec 10, 2025

(cherry picked from commit eaafd7c) (cherry picked from commit 1905046)

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Matous Kozak <matouskozak@seznam.cz>
(cherry picked from commit eaafd7c)
(cherry picked from commit 1905046)
Copilot AI review requested due to automatic review settings December 10, 2025 23:56
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the default macOS build images from macOS 13 to macOS 15 (with Xcode 16) for public builds, and adds test exclusions for Swift interop stress tests that are incompatible with the new environment.

  • Updates public macOS build pool to use 'macos-15' image
  • Adds documentation comment explaining that build platforms should always use the latest available version
  • Excludes Swift ABI stress tests for mono minijit x64 configuration due to known issues on the new platform

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/pipelines/common/xplat-setup.yml Updates public macOS pool from 'macos-13' to 'macos-15' and adds policy comment about using latest platform versions
src/tests/issues.targets Adds test exclusions for Swift interop stress tests (SwiftRetAbiStress and SwiftCallbackAbiStress) for mono minijit x64 configuration, referencing issue #121983

@agocke agocke changed the title Move default build images to macos 15 (and xcode 16) (#120589) [release/8.0] Move default build images to macos 15 (and xcode 16) (#120589) Dec 11, 2025
@agocke agocke added the Servicing-approved Approved for servicing release label Dec 11, 2025
@agocke
Copy link
Member Author

agocke commented Dec 11, 2025

@steveisok it looks like mono build is failing. Any insight?

@steveisok
Copy link
Member

@steveisok it looks like mono build is failing. Any insight?

Taking a look.

@steveisok steveisok requested review from lewing and removed request for lambdageek December 11, 2025 20:26
lambdageek
lambdageek previously approved these changes Dec 11, 2025
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is cherrypicking from c48aa81

I don't remember the subtleties anymore, but this seems right

@lambdageek lambdageek dismissed their stale review December 11, 2025 22:16

not quite there yet

@lambdageek
Copy link
Member

lambdageek commented Dec 11, 2025

@steveisok I think you also need c48aa81#diff-b2942ad0f35c702862be561fa03e56f885e6b362b4b5522a21e23cc4d9e444ba the aot-compiler.c changes

@lambdageek
Copy link
Member

lambdageek commented Dec 11, 2025

On main this line

MONO_EMIT_NEW_LCOMPARE_IMM (cfg, ins->sreg1, (-(int)2147483648));

has INT_MIN

MONO_EMIT_NEW_LCOMPARE_IMM (cfg, ins->sreg1, INT_MIN);

fixed here:

c85492f

@steveisok
Copy link
Member

fixed here:

c85492f

Thanks!

@akoeplinger akoeplinger added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 12, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member

The crashes we see on Build Libraries Test Run release coreclr osx x64 Debug look related, we're seeing them on #122422 as well

@agocke
Copy link
Member Author

agocke commented Dec 12, 2025

Yeah, it looks like Roslyn is somehow entering infinite recursion. @AaronRobinsonMSFT @davidwrighton any immediate ideas based on the stack traces? The only change here is updating the mac build baseline.

@akoeplinger
Copy link
Member

akoeplinger commented Dec 16, 2025

@agocke given it is just one job should we disable the affected test projects and file an issue to unblock the PR(s)?

@agocke
Copy link
Member Author

agocke commented Dec 16, 2025

@akoeplinger It's not one job, it's dozens of tests in 5 different test projects.

@akoeplinger
Copy link
Member

akoeplinger commented Dec 16, 2025

ah sorrry yeah, I just looked at the GitHub status and it doesn't show the full list of failing workitems there

it's still one AzDO job though, so we could also disable the whole job...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants