-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/8.0] Move default build images to macos 15 (and xcode 16) (#120589) #122423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/8.0-staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the default macOS build images from macOS 13 to macOS 15 (with Xcode 16) for public builds, and adds test exclusions for Swift interop stress tests that are incompatible with the new environment.
- Updates public macOS build pool to use 'macos-15' image
- Adds documentation comment explaining that build platforms should always use the latest available version
- Excludes Swift ABI stress tests for mono minijit x64 configuration due to known issues on the new platform
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/common/xplat-setup.yml | Updates public macOS pool from 'macos-13' to 'macos-15' and adds policy comment about using latest platform versions |
| src/tests/issues.targets | Adds test exclusions for Swift interop stress tests (SwiftRetAbiStress and SwiftCallbackAbiStress) for mono minijit x64 configuration, referencing issue #121983 |
|
@steveisok it looks like mono build is failing. Any insight? |
Taking a look. |
…and mess things up.
lambdageek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is cherrypicking from c48aa81
I don't remember the subtleties anymore, but this seems right
|
@steveisok I think you also need c48aa81#diff-b2942ad0f35c702862be561fa03e56f885e6b362b4b5522a21e23cc4d9e444ba the aot-compiler.c changes |
|
On runtime/src/mono/mono/mini/decompose.c Line 221 in ac34532
has runtime/src/mono/mono/mini/decompose.c Line 220 in 30a5c7c
fixed here: |
Thanks! |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
The crashes we see on |
|
Yeah, it looks like Roslyn is somehow entering infinite recursion. @AaronRobinsonMSFT @davidwrighton any immediate ideas based on the stack traces? The only change here is updating the mac build baseline. |
|
@agocke given it is just one job should we disable the affected test projects and file an issue to unblock the PR(s)? |
|
@akoeplinger It's not one job, it's dozens of tests in 5 different test projects. |
|
ah sorrry yeah, I just looked at the GitHub status and it doesn't show the full list of failing workitems there it's still one AzDO job though, so we could also disable the whole job... |
(cherry picked from commit eaafd7c) (cherry picked from commit 1905046)