Skip to content

[main] Source code updates from dotnet/dotnet #121164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[main] Source code updates from dotnet/dotnet #121164

wants to merge 7 commits into from
+136 −138

Conversation

@dotnet-maestro
Copy link
Contributor

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

Associated changes in source repos

@dotnet-maestro
Backflow from https://github.com/dotnet/dotnet / e545239 build 288905
69847a5 
[[ commit created by automation ]]
@dotnet-maestro
Merge main into darc-main-75aed6e3-8eb7-4ec3-bb90-8ef57fa5e2c4
e0a443a
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 288905
b79f58d 
Updated Dependencies:
Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.3.0-1.25523.109 -> 5.3.0-1.25528.108)
Microsoft.CodeAnalysis.NetAnalyzers, Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-rc.2.25523.109 -> 10.0.100-rc.2.25528.108)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 11.0.0-beta.25523.109 -> 11.0.0-beta.25528.108)
Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25523.109 -> 0.11.5-alpha.25528.108)
Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25523.109 -> 2.9.3-beta.25528.108)
Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-rc.1.25523.109 -> 10.0.0-rc.1.25528.108)
NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.0.0-preview.1.2409 -> 7.0.0-preview.1.2908)
System.CommandLine (Version 2.0.0-rc.1.25523.109 -> 2.0.0-rc.1.25528.108)
@github-actions github-actions bot added the area-codeflow for labeling automated codeflow label Oct 29, 2025
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Oct 29, 2025
@akoeplinger
Copy link
Member

@dotnet/jit-contrib can someone please take a look at the JIT.performance test failure?
https://helix.dot.net/api/2019-06-17/jobs/eaf8da08-61ad-4f3c-8283-81022b9b1329/workitems/JIT.performance/console

@akoeplinger
Copy link
Member

oh interesting, it actually fails on mono mini JIT as well with the same error:

08:11:06.027 Running test: JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/regex-redux-1/regex-redux-1.dll
System.ArgumentNullException: Value cannot be null. (Parameter 'stream')
   at System.IO.StreamReader..ctor(Stream stream, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean leaveOpen)
   at System.IO.StreamReader..ctor(Stream stream, Boolean detectEncodingFromByteOrderMarks)
   at System.IO.StreamReader..ctor(Stream stream)
   at BenchmarksGame.RegexRedux_1.TestEntryPoint()
   at Program.<<Main>$>g__TestExecutor74|0_75(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0& )
08:11:06.029 Failed test: JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/regex-redux-1/regex-redux-1.dll
08:11:06.031 Running test: JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/regex-redux-5/regex-redux-5.dll
System.ArgumentNullException: Value cannot be null. (Parameter 'stream')
   at System.IO.StreamReader..ctor(Stream stream, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean leaveOpen)
   at System.IO.StreamReader..ctor(Stream stream, Boolean detectEncodingFromByteOrderMarks)
   at System.IO.StreamReader..ctor(Stream stream)
   at BenchmarksGame.RegexRedux_5.TestEntryPoint()
   at Program.<<Main>$>g__TestExecutor75|0_76(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0& )
08:11:06.033 Failed test: JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/regex-redux-5/regex-redux-5.dll
08:11:06.034 Running test: JIT/Performance/CodeQuality/Benchstones/BenchF/Regula/Regula/Regula.dll
08:11:06.449 Passed test: JIT/Performance/CodeQuality/Benchstones/BenchF/Regula/Regula/Regula.dll
08:11:06.450 Running test: JIT/Performance/CodeQuality/BenchmarksGame/reverse-complement/reverse-complement-1/reverse-complement-1.dll
System.ArgumentNullException: Value cannot be null. (Parameter 'input')
   at System.IO.BinaryReader..ctor(Stream input, Encoding encoding, Boolean leaveOpen)
   at System.IO.BinaryReader..ctor(Stream input)
   at BenchmarksGame.ReverseComplement_1.Bench(Stream input, Stream output)
   at BenchmarksGame.ReverseComplement_1.TestEntryPoint()
   at Program.<<Main>$>g__TestExecutor77|0_78(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0& )
08:11:06.453 Failed test: JIT/Performance/CodeQuality/BenchmarksGame/reverse-complement/reverse-complement-1/reverse-complement-1.dll
08:11:06.454 Running test: JIT/Performance/CodeQuality/BenchmarksGame/reverse-complement/reverse-complement-6/reverse-complement-6.dll
[ERROR] FATAL UNHANDLED EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object
   at BenchmarksGame.ReverseComplement_6.read(Stream stream, Byte[] buffer, Int32 offset, Int32 count)
   at BenchmarksGame.ReverseComplement_6.Reader()
   at System.Threading.Thread.StartCallback()

@akoeplinger
Copy link
Member

ok this seems more like #118475 rather than a JIT issue. @tannergooding any idea why we'd see this again with the RC2 bump?

@tannergooding
Copy link
Member

Did the SDK change or otherwise revert some behavior here again?

@akoeplinger
Copy link
Member

Ah yeah looks like it dotnet/sdk#50502 and dotnet/sdk#50686 (which was merged after RC1 shipped). So I guess we need to revert the resource name lookup changes from #118605

@akoeplinger
Revert resource name lookup change in BenchmarksGame
22e9b75
@akoeplinger
Hardcode SdkVersionForWorkloadTesting for now
2494ba0 
.NET 11 channel still produces a 10.0-rc1 versioned build which causes an issue in WasmBuildTests because it is lower than rc2
This was referenced Oct 29, 2025
Open
Open
Open
Open
Open
@dotnet-maestro
Copy link
Contributor Author

Important

The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes.

Please continue with one of the following options:

  1. Close or merge this PR and let the codeflow continue normally
  2. Close or merge this PR and receive the new codeflow immediately by triggering the subscription:
    darc trigger-subscriptions --id f7901f87-9f24-40d6-9bc1-564863937237
  3. Force-flow new changes into this PR at your own risk (some PR commits might be reverted):
    darc trigger-subscriptions --force --id f7901f87-9f24-40d6-9bc1-564863937237

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

This was referenced Oct 30, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area-codeflow for labeling automated codeflow linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akoeplinger @tannergooding