Fix benchmarksgame tests to be able to resolve the embedded resources #118605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes benchmarksgame tests to properly resolve embedded resources by modifying the resource name generation logic. The issue was that embedded resource names were using hyphens in file names, but the .NET SDK converts hyphens to underscores in resource identifiers.
Key changes:
- Remove
[ActiveIssue]attributes that were disabling the tests - Update resource name generation to replace hyphens with underscores in file names
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| reverse-complement-6.cs | Removes ActiveIssue attribute to re-enable test |
| reverse-complement-1.cs | Removes ActiveIssue attribute to re-enable test |
| reverse-complement/harness-helpers.cs | Updates resource name generation to replace hyphens with underscores |
| regex-redux-5.cs | Removes ActiveIssue attribute to re-enable test |
| regex-redux-1.cs | Removes ActiveIssue attribute to re-enable test |
| regex-redux/harness-helpers.cs | Updates resource name generation to replace hyphens with underscores |
| k-nucleotide-9.cs | Removes ActiveIssue attribute to re-enable test |
| k-nucleotide-1.cs | Removes ActiveIssue attribute to re-enable test |
| k-nucleotide/harness-helpers.cs | Updates resource name generation to replace hyphens with underscores |
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jkotas
approved these changes
Aug 11, 2025
|
/ba-g infrastructure timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #118475
There's still some discussion happening on if the SDK change here needs a breaking change doc or more consideration, but this ensures the tests are running in the interim.