Skip to content

Capture PDBs in --make-repro-path #121163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2025
Merged

Capture PDBs in --make-repro-path #121163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61d4143
Capture PDBs in `--make-repro-path`
MichalStrehovsky Oct 29, 2025
9efa212
Update src/coreclr/tools/Common/CommandLineHelpers.cs
MichalStrehovsky Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/coreclr/tools/Common/CommandLineHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,22 @@ string ConvertFromOriginalPathToReproPackagePath(bool input, string originalPath
string reproFileDir = prefix + originalToReproPackageFileName.Count.ToString() + Path.DirectorySeparatorChar;
reproPackagePath = Path.Combine(reproFileDir, Path.GetFileName(originalPath));
if (!input)
{
archive.CreateEntry(reproFileDir); // for outputs just create output directory
}
else
{
archive.CreateEntryFromFile(originalPath, reproPackagePath);

// The compiler probes for .pdb files next to input assemblies. For simplicity, just try to look
// for PDB next to any file we package.
string originalPdbPath = Path.ChangeExtension(originalPath, "pdb");
if (!string.Equals(originalPath, originalPdbPath, StringComparison.InvariantCultureIgnoreCase)
&& File.Exists(originalPdbPath))
{
archive.CreateEntryFromFile(originalPdbPath, Path.ChangeExtension(reproPackagePath, "pdb"));
}
}
originalToReproPackageFileName.Add(originalPath, reproPackagePath);

return reproPackagePath;
Expand Down
Loading