Capture PDBs in --make-repro-path
#121163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repro for #121012 was somewhat harder to obtain because we don't pack PDBs into the repro package (they are not command line arguments and the compiler looks for them next to the assembly). This is a simple change to just look for .pdb files next to the files we're packing.
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the repro package creation functionality to automatically include PDB (Program Database) files when packaging input assemblies. The change enables better debugging support for repro packages by ensuring that symbol files are included alongside their corresponding assemblies.
Key Changes
- Added automatic detection and packaging of PDB files next to input assemblies
- Added braces around single-line if/else blocks for consistency with the new multi-line else block
Open
3 tasks
jkotas
added
area-NativeAOT-coreclr
and removed
needs-area-label
jkotas
reviewed
Oct 29, 2025
agocke
approved these changes
Oct 31, 2025
jkotas
reviewed
Oct 31, 2025
jkotas
approved these changes
Oct 31, 2025
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Member
|
/ba-g infrastructure timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro for dotnet/roslyn#80952 was somewhat harder to obtain because we don't pack PDBs into the repro package (they are not command line arguments and the compiler looks for them next to the assembly).
This is a simple change to just look for .pdb files next to the files we're packing.
Cc @dotnet/ilc-contrib