Make the include directory inclusion the same for both paths. #120991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
requested review from
EgorBo,
jkoritzinsky and
max-charlamb
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the setting of include directories for data descriptor targets in the CMake build configuration. Instead of duplicating target_include_directories calls in both the stub path and the cdac-build-tool path, the calls are now unified at the end of the function to apply to both paths equally.
Key Changes:
- Removed duplicate
target_include_directoriescalls from both conditional branches - Added a single pair of
target_include_directoriescalls at the end of the function that applies to both the stub and generated descriptor paths
jkoritzinsky
approved these changes
Oct 22, 2025
|
/ba-g Failures are unrelated and reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #120921 (comment)