Skip to content

Conversation

@AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Oct 22, 2025

Reverts #120234

This change appears to have broken the boot strapped community builds.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the migration of hosting tests from XUnit v2 to XUnit v3, rolling back changes made in PR #120234. The revert restores the previous test infrastructure, including test runner configuration, execution commands, and build settings.

Key changes:

  • Reverts test execution from native binary to dotnet test command
  • Restores XUnit v2 packages and removes XUnit v3 dependencies
  • Reverts HostTestContext back to TestContext class name
  • Restores platform-specific test filtering using attributes instead of runtime checks

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/installer/tests/helixpublish.proj Reverts test execution command from native binary to dotnet test, removes runtime-specific CLI configuration
src/installer/tests/TestUtils/TestUtils.csproj Switches XUnit packages from v3 back to v2
src/installer/tests/TestUtils/TestContext.cs Renames HostTestContext class back to TestContext
src/installer/tests/TestUtils/*.cs Updates references from HostTestContext to TestContext throughout utility classes
src/installer/tests/*/Tests.csproj Removes XUnit v3 configuration properties (OutputType, RuntimeIdentifier, TestRunnerName)
src/installer/tests/HostActivation.Tests/*.cs Updates all test references from HostTestContext to TestContext, restores [PlatformSpecific] attributes
src/installer/tests/Directory.Build.props Reverts test runner arguments and filter syntax from XUnit v3 to v2 format
src/installer/tests/Directory.Build.targets Removes XUnit v3-specific crash/hang dump package references

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT
Copy link
Member Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@AaronRobinsonMSFT
Copy link
Member Author

See #120234 (comment) for a follow up suggestion for hosting changes.

@Youssef1313
Copy link
Member

@AaronRobinsonMSFT It would be nice to have more info in PR description about what exactly broke and/or why.

@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Oct 23, 2025

@Youssef1313 As I stated, it is the boot strapping steps for the community builds - freebsd, loongarch and risc-v. These have dependencies on an LKG of the runtime, but those platforms don't have that. We have a partial set-up that makes those platforms run, but alas something in the hosting tests appears to have broken that. What that is is not clear to me, but this PR appeared to be the most likely culprit so I'm reverting it. My guess is this has to do with some bad assumption in the bootstrapping of those platforms rather than anything to do with the changes themselves.

See #120991 for the failing legs.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 8e20ce4 into main Oct 23, 2025
78 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the revert-120234-apphost-tests-xunit3 branch October 23, 2025 02:31
@jkotas
Copy link
Member

jkotas commented Oct 23, 2025

My guess is this has to do with some bad assumption in the bootstrapping

  • After the XUnit 3, the tests want to restore apphost for the target architecture from the nuget. This looks suspect. The tests should be testing fresh bits produced by local build, not some old published bits.
  • We are building tests as part of the product build. It is unnecessary.

(Both of these issues should be fixed.)

@AaronRobinsonMSFT
Copy link
Member Author

(Both of these issues should be fixed.)

@jkotas Agree. We're going to add a trigger for this with #120999 so when this fix is tried again, we can get better validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants