-
Couldn't load subscription status.
- Fork 5.2k
Revert "Move hosting tests to XUnit 3" #120997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 1e7ee6f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the migration of hosting tests from XUnit v2 to XUnit v3, rolling back changes made in PR #120234. The revert restores the previous test infrastructure, including test runner configuration, execution commands, and build settings.
Key changes:
- Reverts test execution from native binary to
dotnet testcommand - Restores XUnit v2 packages and removes XUnit v3 dependencies
- Reverts
HostTestContextback toTestContextclass name - Restores platform-specific test filtering using attributes instead of runtime checks
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/installer/tests/helixpublish.proj | Reverts test execution command from native binary to dotnet test, removes runtime-specific CLI configuration |
| src/installer/tests/TestUtils/TestUtils.csproj | Switches XUnit packages from v3 back to v2 |
| src/installer/tests/TestUtils/TestContext.cs | Renames HostTestContext class back to TestContext |
| src/installer/tests/TestUtils/*.cs | Updates references from HostTestContext to TestContext throughout utility classes |
| src/installer/tests/*/Tests.csproj | Removes XUnit v3 configuration properties (OutputType, RuntimeIdentifier, TestRunnerName) |
| src/installer/tests/HostActivation.Tests/*.cs | Updates all test references from HostTestContext to TestContext, restores [PlatformSpecific] attributes |
| src/installer/tests/Directory.Build.props | Reverts test runner arguments and filter syntax from XUnit v3 to v2 format |
| src/installer/tests/Directory.Build.targets | Removes XUnit v3-specific crash/hang dump package references |
...taller/tests/HostActivation.Tests/NativeHosting/HostContext.PropertyCompatibilityTestData.cs
Show resolved
Hide resolved
...aller/tests/HostActivation.Tests/NativeHosting/HostContext.FrameworkCompatibilityTestData.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
|
/azp list |
|
See #120234 (comment) for a follow up suggestion for hosting changes. |
|
@AaronRobinsonMSFT It would be nice to have more info in PR description about what exactly broke and/or why. |
|
@Youssef1313 As I stated, it is the boot strapping steps for the community builds - freebsd, loongarch and risc-v. These have dependencies on an LKG of the runtime, but those platforms don't have that. We have a partial set-up that makes those platforms run, but alas something in the hosting tests appears to have broken that. What that is is not clear to me, but this PR appeared to be the most likely culprit so I'm reverting it. My guess is this has to do with some bad assumption in the bootstrapping of those platforms rather than anything to do with the changes themselves. See #120991 for the failing legs. |
(Both of these issues should be fixed.) |
Reverts #120234
This change appears to have broken the boot strapped community builds.