add GC_CONFIG_DRIVEN define to standalone GC builds#119535
Merged
max-charlamb merged 1 commit intodotnet:mainfrom Sep 10, 2025
Merged
add GC_CONFIG_DRIVEN define to standalone GC builds#119535max-charlamb merged 1 commit intodotnet:mainfrom
max-charlamb merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the GC_CONFIG_DRIVEN define to standalone GC builds to align with built-in GC configuration. The change addresses a discrepancy where DAC (Debug Access Component) logic expects this define to be present, but standalone GC builds were missing it, leading to inconsistent behavior between built-in and standalone GC implementations.
Key Changes
- Adds
GC_CONFIG_DRIVENdefinition to standalone GC CMake configuration
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
mangod9
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #119324.
GC_CONFIG_DRIVENis always defined in the built-in GC, but not in standalone builds.Logic in the DAC checks this define. However, the define has different values in the GC and DAC which leads to unintended behavior.
Discussed with @jkotas and agreed that
GC_CONFIG_DRIVENnot being defined in the standalone GC builds is most likely an oversight and it can always be defined.Planning to add a test in the SOS test suite which invokes GC APIs on standalone GCs.