[cDAC] Remaining GC data APIs#119324
Merged
max-charlamb merged 17 commits intodotnet:mainfrom Sep 22, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Open
3 tasks
This was referenced Sep 5, 2025
This was referenced Sep 8, 2025
…runtime into cdac-dynamicadaptationmode
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the remaining GC data APIs for the cDAC (compact Data Access Component) system, completing the transition from legacy DAC implementations. The changes focus on providing structured access to garbage collector internal data including heap analysis, segment information, out-of-memory data, and global GC mechanisms.
Key changes implemented:
- Implementation of heap analysis APIs (GetHeapAnalyzeData, GetHeapAnalyzeStaticData)
- Addition of heap segment data access (GetHeapSegmentData)
- Out-of-memory data retrieval APIs (GetOOMData, GetOOMStaticData)
- GC interesting info and global mechanisms APIs
- Dynamic adaptation mode support
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SOSDacImpl.cs | Implements concrete API methods replacing legacy delegations with cDAC implementations |
| ISOSDacInterface.cs | Updates interface definitions with strongly-typed parameters and adds new data structures |
| OOMHistory.cs | New data structure for out-of-memory history tracking |
| HeapSegment.cs | New data structure for heap segment information |
| GCHeapSVR.cs | Enhanced server GC heap data structure with additional fields for analysis |
| IGCHeap.cs | New interface defining common GC heap operations |
| GC_1.cs | Core GC contract implementation with new data retrieval methods |
| GCHeapWKS.cs | New workstation GC heap implementation |
| Constants.cs | Added global constants for new GC data arrays and mechanisms |
| DataType.cs | Added new data types for heap segments and OOM history |
| IGC.cs | Extended interface with new API signatures and data structures |
| datadescriptor.inc | Added C++ data descriptors for new heap segment and OOM history types |
| datadescriptor.h | Added field mappings for GC heap analysis and interesting data |
| GC.md | Updated documentation with new API signatures and data structures |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/GC/GC_1.cs
Outdated
Show resolved
Hide resolved
Member
|
fyi @Maoni0 |
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Member
|
CC @mangod9 |
mangod9
reviewed
Sep 17, 2025
...ve/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/GC/GCHeapWKS.cs
Show resolved
Hide resolved
mangod9
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APIs Implemented
internal_root_array#119396Test run against new runtime-diagnostic tests: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1144229&view=results