Improve exception messages in IPAddress class for (ReadOnlyIPAddress, AddressFamily IPv4/IPv6) #118917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
huoyaoyuan
reviewed
Aug 20, 2025
src/libraries/System.Net.Primitives/src/System/Net/IPAddress.cs
Outdated
Show resolved
Hide resolved
…ed error with improved message clarity
ArminShoeibi
force-pushed
the
issues-118727-stj
branch
from
914c278 to
cf42818
Compare
MihaZupan
reviewed
Aug 20, 2025
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
MihaZupan
approved these changes
Aug 20, 2025
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
Please also add a test for the read-only case.
Otherwise this LGTM, thank you!
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Contributor
Author
Sure, I'll add the test for the read-only case too. |
ArminShoeibi
force-pushed
the
issues-118727-stj
branch
from
dbcd329 to
b5098be
Compare
ArminShoeibi
changed the title
MihaZupan
reviewed
Aug 21, 2025
src/libraries/System.Net.Primitives/tests/FunctionalTests/IPAddressTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Primitives/tests/FunctionalTests/IPAddressTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Primitives/tests/FunctionalTests/IPAddressTest.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #118727
Hey there, I will make the PR ready in 1 day. its WIP for now.
Cc: @MihaZupan