Skip to content

Commit 914c278

Browse files
committed
Add a general mesasge in the Strings.resx
1 parent 64561cb commit 914c278

File tree

3 files changed

+68
-7
lines changed

3 files changed

+68
-7
lines changed

src/libraries/System.Net.Primitives/src/Resources/Strings.resx

Lines changed: 64 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,64 @@
1-
<root>
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<root>
3+
<!--
4+
Microsoft ResX Schema
5+
6+
Version 2.0
7+
8+
The primary goals of this format is to allow a simple XML format
9+
that is mostly human readable. The generation and parsing of the
10+
various data types are done through the TypeConverter classes
11+
associated with the data types.
12+
13+
Example:
14+
15+
... ado.net/XML headers & schema ...
16+
<resheader name="resmimetype">text/microsoft-resx</resheader>
17+
<resheader name="version">2.0</resheader>
18+
<resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
19+
<resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
20+
<data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
21+
<data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
22+
<data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
23+
<value>[base64 mime encoded serialized .NET Framework object]</value>
24+
</data>
25+
<data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
26+
<value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
27+
<comment>This is a comment</comment>
28+
</data>
29+
30+
There are any number of "resheader" rows that contain simple
31+
name/value pairs.
32+
33+
Each data row contains a name, and value. The row also contains a
34+
type or mimetype. Type corresponds to a .NET class that support
35+
text/value conversion through the TypeConverter architecture.
36+
Classes that don't support this are serialized and stored with the
37+
mimetype set.
38+
39+
The mimetype is used for serialized objects, and tells the
40+
ResXResourceReader how to depersist the object. This is currently not
41+
extensible. For a given mimetype the value must be set accordingly:
42+
43+
Note - application/x-microsoft.net.object.binary.base64 is the format
44+
that the ResXResourceWriter will generate, however the reader can
45+
read any of the formats listed below.
46+
47+
mimetype: application/x-microsoft.net.object.binary.base64
48+
value : The object must be serialized with
49+
: System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
50+
: and then encoded with base64 encoding.
51+
52+
mimetype: application/x-microsoft.net.object.soap.base64
53+
value : The object must be serialized with
54+
: System.Runtime.Serialization.Formatters.Soap.SoapFormatter
55+
: and then encoded with base64 encoding.
56+
57+
mimetype: application/x-microsoft.net.object.bytearray.base64
58+
value : The object must be serialized into a byte array
59+
: using a System.ComponentModel.TypeConverter
60+
: and then encoded with base64 encoding.
61+
-->
262
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
363
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
464
<xsd:element name="root" msdata:IsDataSet="true">
@@ -117,4 +177,7 @@
117177
<data name="PlatformNotSupported_NetPrimitives" xml:space="preserve">
118178
<value>System.Net.Primitives is not supported on this platform.</value>
119179
</data>
180+
<data name="net_SocketException_OperationNotSupported" xml:space="preserve">
181+
<value>The requested property is not supported for the current AddressFamily '{0}'. Use ScopeId for IPv6 or Address for IPv4 as appropriate.</value>
182+
</data>
120183
</root>

src/libraries/System.Net.Primitives/src/System/Net/IPAddress.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -771,9 +771,7 @@ public IPAddress MapToIPv4()
771771
[DoesNotReturn]
772772
private void ThrowSocketOperationNotSupported()
773773
{
774-
string message = IsIPv4 ? "The requested operation is not supported for IPv4 addresses." :
775-
"The requested operation is not supported for IPv6 addresses.";
776-
throw new SocketException(SocketError.OperationNotSupported, message);
774+
throw new SocketException(SocketError.OperationNotSupported, SR.Format(SR.net_SocketException_OperationNotSupported, AddressFamily));
777775
}
778776

779777
private sealed class ReadOnlyIPAddress : IPAddress

src/libraries/System.Net.Primitives/tests/FunctionalTests/IPAddressTest.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ public static IEnumerable<object[]> GetValidIPAddresses()
306306
{
307307
return IPAddressParsingFormatting.ValidIpv4Addresses
308308
.Concat(IPAddressParsingFormatting.ValidIpv6Addresses)
309-
.Select(array => new object[] {IPAddress.Parse((string)array[0])});
309+
.Select(array => new object[] { IPAddress.Parse((string)array[0]) });
310310
}
311311

312312
public static readonly object[][] GeneratedIPAddresses =
@@ -358,7 +358,7 @@ public static void ScopeId_ThrowsIPv4SpecificMessage()
358358
var ip = IPV4Address1();
359359
SocketException ex = Assert.Throws<SocketException>(() => _ = ip.ScopeId);
360360
Assert.Equal((int)SocketError.OperationNotSupported, ex.ErrorCode);
361-
Assert.Contains("IPv4 addresses", ex.Message);
361+
Assert.Contains("AddressFamily 'InterNetwork'", ex.Message);
362362
}
363363

364364
[Fact]
@@ -367,7 +367,7 @@ public static void Address_ThrowsIPv6SpecificMessage()
367367
var ip = IPV6Address1();
368368
SocketException ex = Assert.Throws<SocketException>(() => _ = ip.Address);
369369
Assert.Equal((int)SocketError.OperationNotSupported, ex.ErrorCode);
370-
Assert.Contains("IPv6 addresses", ex.Message);
370+
Assert.Contains("AddressFamily 'InterNetworkV6'", ex.Message);
371371
}
372372
#pragma warning restore 618
373373
}

0 commit comments

Comments
 (0)