JIT: Build community JITs on Windows in superpmi-diffs again #118437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we changed to run superpmi-diffs on macOS arm64, we lost the build of the community JITs on Windows. This was switched over to build in superpmi-replay, but that pipeline does not run on all JIT PRs. Readd the Windows build back to ensure compiler errors do not slip in for the community JITs.
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
/azp run runtime-coreclr superpmi-diffs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-coreclr superpmi-diffs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit dc18cae.
Member
Author
|
PTAL @dotnet/jit-contrib |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a CI pipeline issue where community JITs were not being built on Windows in the superpmi-diffs pipeline after #116299 switched the pipeline to run on macOS arm64. The fix ensures community JITs get proper build coverage on JIT PRs by:
- Restoring Windows x64 build in superpmi-diffs pipeline for community JIT build coverage
- Switching superpmi-diffs to build community JITs specifically instead of all JITs
- Switching jit-replay-pipeline to build all JITs instead of just community JITs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/coreclr/templates/jit-replay-pipeline.yml | Changes build args from community JITs to all JITs |
| eng/pipelines/coreclr/superpmi-diffs.yml | Adds Windows x64 platform and switches to building community JITs with explanatory comment |
AndyAyersMS
approved these changes
Aug 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #116299 superpmi-diffs was changed to run on macOS arm64. When doing so we lost the build of the community JITs on Windows. This was switched over to build in superpmi-replay, but that pipeline does not run on all JIT PRs.
We have had a couple of build breaks since then (e.g. #118407), so readd the Windows build back to ensure compiler errors do not slip in for the community JITs.