JIT: Fix RISC-V emitter build #118407
Merged
JIT: Fix RISC-V emitter build #118407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet/jit-contrib PTAL, thanks! |
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build issue in the RISC-V JIT emitter that was causing SPMI replay runs to fail. The issue was related to an implicit pointer arithmetic conversion that needed explicit casting.
Key Changes
- Added explicit cast to convert pointer difference to unsigned integer
- Added assertion to validate the pointer arithmetic result
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/samsung Could you please take a look? These changes may be related to riscv64. |
tomeksowi
approved these changes
Aug 6, 2025
jakobbotsch
approved these changes
Aug 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPMI replay runs are red from this (example).