-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Adding GetTLSIndex cDAC implementation #117587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements cDAC support for retrieving the TLS index on a target runtime.
- Added the GetTLSIndex method in
SOSDacImpl.cs
with low-level reads, error handling, and debug assertions against the legacy DAC. - Introduced new constants
TlsIndex
andTlsOutOfIndexes
in the data contract for TLS globals. - Exposed
TLS_OUT_OF_INDEXES
andg_TlsIndex
indatadescriptor.h
for cDAC consumption.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs | Implements GetTLSIndex logic, argument validation, and debug checks |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Constants.cs | Adds TlsIndex and TlsOutOfIndexes to the Globals contract |
src/coreclr/debug/runtimeinfo/datadescriptor.h | Declares CDAC globals for TlsOutOfIndexes and TlsIndex |
Comments suppressed due to low confidence (1)
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs:1646
- Add unit tests for
GetTLSIndex
covering successful index retrieval, the S_FALSE case whenTlsIndex == TlsOutOfIndexes
, and error paths to ensure the implementation behaves as expected.
int ISOSDacInterface.GetTLSIndex(uint* pIndex)
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
/ba-g android-x64 Release AllSubsets_CoreCLR timeout |
LGTM otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/ba-g baseservices-exceptions Work Item failure |
No description provided.