MSBUILD Server dogfood #115766
MSBUILD Server dogfood #115766
Conversation
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR enables the MSBuild server feature in CI by setting the MSBUILDUSESERVER variable.
- Introduces a new pipeline variable to dogfood the MSBuild server
- Enables internal rollout for AspNetCore builds
Comments suppressed due to low confidence (1)
eng/pipelines/common/variables.yml:47
- [nitpick] The variable name is in all-caps without separators; consider using a consistent naming style (e.g., camelCase or kebab-case) to match other pipeline variables.
name: MSBUILDUSESERVER
|
Note: I'm not familiar with your pipelines. Turning on MSBUILD server is done via setting the environment variable MSBUILSUSESERVER to 1 so that is what I was trying to achieve. While checking the binlog of the failed check it claims that MSBUILDUSESERVER=0 so I probably placed the variable at a wrong spot. |
|
@jkoritzinsky where's the best place to set an env var in runtime's YML that should impact all msbuild invocations? |
|
I'd put it in global-build-step.yml. That will catch almost all product builds (not runtime tests). |
SimaTian
requested review from
jeffhandley,
a team,
marek-safar,
sbomer,
lewing,
akoeplinger,
pavelsavara,
maraf,
thaystg,
ilonatommy,
steveisok,
vitek-karas,
BrzVlad,
kotlarmilos,
lateralusX,
MichalStrehovsky,
janvorli and
kg
as code owners
SimaTian
force-pushed
the
MSBUILD-dogfood
branch
from
680efcb to
3c7d4c1
Compare
SimaTian
force-pushed
the
MSBUILD-dogfood
branch
from
d0c81b5 to
270100d
Compare
SimaTian
force-pushed
the
MSBUILD-dogfood
branch
from
270100d to
0364fa6
Compare
Removed redundant environment variable definitions for MSBUILDUSESERVER and DOTNET_CLI_USE_MSBUILD_SERVER.
…nto MSBUILD-dogfood
* updating based on review with Jemery Koritzinsky * Clean up environment variable definitions Removed redundant environment variable definitions for MSBUILDUSESERVER and DOTNET_CLI_USE_MSBUILD_SERVER. * adding an escape hatch for the dogfood * minor cleanup * Fix environment variable name for MSBuild server * affordance for old powershell
|
I do not see the intermittent build failures anymore after the revert. |
MSBUILD Server dogfood
Part of #9379
Please help us with our dofgooding effort for the MSBuild server feature.
For now we've dogfooded internally for our pipelines, we're running without issues within Aspnetcore and we would like to continue the rollout before we're confident enough to make Server build the new default.