Skip to content

MSBUILD Server dogfood #115766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MSBUILD Server dogfood #115766

wants to merge 1 commit into from

Conversation

SimaTian
Copy link
Member

MSBUILD Server dogfood

Part of #9379

Please help us with our dofgooding effort for the MSBuild server feature.
For now we've dogfooded internally for our pipelines, we're running without issues within Aspnetcore and we would like to continue the rollout before we're confident enough to make Server build the new default.

@Copilot Copilot AI review requested due to automatic review settings May 20, 2025 07:58
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 20, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the MSBuild server feature in CI by setting the MSBUILDUSESERVER variable.

  • Introduces a new pipeline variable to dogfood the MSBuild server
  • Enables internal rollout for AspNetCore builds
Comments suppressed due to low confidence (1)

eng/pipelines/common/variables.yml:47

  • [nitpick] The variable name is in all-caps without separators; consider using a consistent naming style (e.g., camelCase or kebab-case) to match other pipeline variables.
name: MSBUILDUSESERVER

@SimaTian
Copy link
Member Author

SimaTian commented May 20, 2025

Note: I'm not familiar with your pipelines. Turning on MSBUILD server is done via setting the environment variable MSBUILSUSESERVER to 1 so that is what I was trying to achieve.
If there is a better place to do it, please let me know.

While checking the binlog of the failed check it claims that MSBUILDUSESERVER=0 so I probably placed the variable at a wrong spot.
Or maybe I have to set env:MSBUILDUSESERVER=1 instead?
Any insight will be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant