MSBUILD Server dogfood (#115766)

* updating based on review with Jemery Koritzinsky

* Clean up environment variable definitions

Removed redundant environment variable definitions for MSBUILDUSESERVER and DOTNET_CLI_USE_MSBUILD_SERVER.

* adding an escape hatch for the dogfood

* minor cleanup

* Fix environment variable name for MSBuild server

* affordance for old powershell

Author: SimaTian

eng/build.ps1

@@ -266,6 +266,16 @@ if ($vs) {
   # Disable .NET runtime signature validation errors which errors for local builds
   $env:VSDebugger_ValidateDotnetDebugLibSignatures=0;
 
+  # MSBuild Server dogfood.
+  if ($env:DOTNET_CLI_USE_MSBUILD_SERVER -eq $null) 
+  {
+    $env:DOTNET_CLI_USE_MSBUILD_SERVER = 1
+  }
+  if ($env:MSBUILDUSESERVER -eq $null) 
+  {
+    $env:MSBUILDUSESERVER = 1
+  }
+
   # Respect the RuntimeConfiguration variable for building inside VS with different runtime configurations
   if ($runtimeConfiguration)
   {

eng/build.sh

@@ -14,6 +14,10 @@ while [[ -h "$source" ]]; do
 done
 scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
 
+# MSBuild Server dogfood.
+export MSBUILDUSESERVER="${MSBUILDUSESERVER:-1}"
+export DOTNET_CLI_USE_MSBUILD_SERVER="${DOTNET_CLI_USE_MSBUILD_SERVER:-1}"
+
 usage()
 {
   echo "Common settings:"

eng/pipelines/common/global-build-job.yml

@@ -81,6 +81,10 @@ jobs:
         - ${{ format('build_{0}{1}_{2}_{3}_{4}', parameters.osGroup, parameters.osSubgroup, parameters.archType, coalesce(globalBuild.buildConfig, parameters.buildConfig), globalBuild.nameSuffix) }}
 
     variables:
+      - name: "MSBUILDUSESERVER"
+        value: "1"
+      - name: "DOTNET_CLI_USE_MSBUILD_SERVER"
+        value: "1"
       - ${{ if eq(variables['System.TeamProject'], 'internal') }}:
           - group: DotNet-HelixApi-Access
           - group: AzureDevOps-Artifact-Feeds-Pats

eng/pipelines/common/templates/global-build-step.yml

@@ -12,6 +12,9 @@ parameters:
 steps:
   - script: $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci ${{ parameters.archParameter }} $(_osParameter) ${{ parameters.crossArg }} ${{ parameters.buildArgs }} ${{ parameters.targetCxxLibraryConfigurationArgs }} $(_officialBuildParameter) $(_overrideTestScriptWindowsCmdParameter)
     displayName: ${{ parameters.displayName }}
+    env:
+      MSBUILDUSESERVER: '1'
+      DOTNET_CLI_USE_MSBUILD_SERVER: '1'
     ${{ if eq(parameters.useContinueOnErrorDuringBuild, true) }}:
       continueOnError: ${{ parameters.shouldContinueOnError }}
     ${{ if ne(parameters.container, '') }}:

eng/pipelines/global-build.yml

@@ -60,6 +60,9 @@ extends:
                 eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true),
                 eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_non_mono_and_wasm.containsChange'], true),
                 eq(variables['isRollingBuild'], true))
+          env:
+            MSBUILDUSESERVER: 1
+            DOTNET_CLI_USE_MSBUILD_SERVER: 1
 
       #
       # Build with RuntimeFlavor only. This exercise code paths where only RuntimeFlavor is