Skip to content

[manual] Merge release/8.0-staging into release/8.0 #115498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 15, 2025

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented May 12, 2025

MERGE COMMIT

dotnet-maestro bot and others added 14 commits April 15, 2025 11:03
…114441)

* Update dependencies from https://github.com/dotnet/arcade build 20250408.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25164.5 -> To Version 8.0.0-beta.25208.7

* Update dependencies from https://github.com/dotnet/arcade build 20250414.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25164.5 -> To Version 8.0.0-beta.25214.7

* Update MicrosoftDotnetSdkInternalVersion to 8.0.115

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
…ease/8.0-staging

[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
After the recent VS upgrade from 17.12.5 to 17.13.2 we started seeing access violations in the mono-aot-cross.exe when targetting wasm.

We tracked it down to sgen_clz being miscompiled, we can workaround the compiler bug by switching from ternary condition to if/else.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
…dotnet#114906)

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
…OS/tvOS simulator jobs to `osx.14.arm64.open` and `osx.15.amd64.open` queues (dotnet#114633)

iOSSimulator, tvOSSimulator, MacCatalyst pipelines are migrated to:
- `osx.15.amd64.open`
- `osx.14.arm64.open` (until `osx.15.arm64.open` has enough machines)

## Newly failing test scenarios
Some new failures were discovered during the migration. The tests were disabled and tracking issues were open to monitor progress for enablement.
- System.Net.Sockets.Tests.SocketOptionNameTest.MulticastInterface_Set_AnyInterface_Succeeds
- System.IO.IsolatedStorage
- System.IO. MemoryMappedFiles
- System.Net.Sockets.Tests.SendTo_.*.Datagram_UDP_AccessDenied_Throws_DoesNotBind
…dotnet#115012)

I noticed we were sending 30k workitems each day to various Helix queues, this is due to the outerloop pipeline having a schedule triggere which matches old preview branches or the staging branches.

This fixes that and also sets it so that the trigger only applies if there are actual source changes.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Fix Idn tests

[Test Only] Port the Idna test fixes to support Unicode 15

* Minor fix

* Fine tune the idn to Unicode versions

* Add missing files
* new-dfr in one commit

* fixes for decommitting large+huge and comments

* only age regions during BGC

* fix age_all_region_kinds condition.

* fixing merge conflict.

* fix merge issues.

* PR Feedback

---------

Co-authored-by: Mark Plesko <markples@microsoft.com>
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
…ease/8.0-staging

[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
@jozkee jozkee requested review from a team and Copilot May 12, 2025 23:07
@jozkee jozkee added the NO-SQUASH The PR should not be squashed label May 12, 2025
@jozkee jozkee requested review from thaystg and radical as code owners May 12, 2025 23:07
@jozkee jozkee added the Servicing-approved Approved for servicing release label May 12, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs a merge of release/8.0-staging into release/8.0 with primarily merge commit changes. The key updates include new Unicode test files (for Unicode 15.0, 15.1, and 16.0), ICU version threshold updates in the test factory, modifications to GC free region enums and related constants, and updates to various project and pipeline configuration files.

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/libraries/System.Globalization.Extensions/tests/NlsTests/System.Globalization.Extensions.Nls.Tests.csproj Added new Compile and EmbeddedResource entries for Unicode 15.0 and 16.0 test files
src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/* New or updated test files and ReadMe documentation for Unicode 15.0, 15.1, and 16.0
src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/Factory.cs Adjusted ICU version thresholds to select test data based on newer ICU versions
src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/ConformanceIdna* New overloads and property additions to support source tracking in test results
src/libraries/System.DirectoryServices.Protocols/src/System.DirectoryServices.Protocols.csproj Updated package generation and servicing version settings
src/coreclr/gc/gcpriv.h Revised free region enumeration with explicit numeric assignments and introduced specialized decommit age constants
eng/pipelines/* Various updates to pipeline YAML files reflecting updated branch filters, image versions, and scheduling conditions
Comments suppressed due to low confidence (3)

src/libraries/System.DirectoryServices.Protocols/src/System.DirectoryServices.Protocols.csproj:7

  • Verify that changing GeneratePackageOnBuild to true and updating ServicingVersion to 2 is intentional, as these settings will affect package distribution.
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>

src/libraries/System.Globalization.Extensions/tests/IdnMapping/Data/Factory.cs:29

  • Confirm that updating the ICU version threshold from 74.0 to 76.0 for selecting Unicode 16.0 test data aligns with the intended support and test coverage.
if (PlatformDetection.ICUVersion >= new Version(76, 0))

src/coreclr/gc/gcpriv.h:5286

  • Ensure that the new decommit age constants for basic, large, and huge free regions (introduced with AGE_IN_FREE_TO_DECOMMIT_BASIC, _LARGE, and _HUGE) reflect the intended GC tuning parameters.
#define AGE_IN_FREE_TO_DECOMMIT_BASIC 20

@jozkee
Copy link
Member Author

jozkee commented May 15, 2025

/ba-g #114924. Not sure why it wasn't caught by build analysis.

@jozkee jozkee merged commit 6aebff6 into dotnet:release/8.0 May 15, 2025
350 of 384 checks passed
@jozkee jozkee deleted the release/8.0-staging branch May 15, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO-SQUASH The PR should not be squashed Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants