[release/8.0-staging] Strip trailing slash from source dir for cmake4 #114906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
This was referenced Apr 22, 2025
|
Infrastructure/build-only change required to build with newer cmake versions, tell mode, applying servicing-approved. |
|
/ba-g unrelated test failures |
akoeplinger
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #114779 to release/8.0-staging
/cc @akoeplinger @am11
Customer Impact
When building with cmake 4.0 it doesn't like a trailing slash in the source dir argument. We tried to strip the slash already but due to a copy/paste mistake we never actually did it and it went unnoticed until now.
Regression
We never noticed that we didn't strip the slash. We'll hit this as soon as the infrastructure is updated to use cmake 4.0.
Testing
CI testing.
Risk
Low. We already have the same code in other parts of the build.