Skip to content

Make sure we add the System.Private.* assemblies when using the NativeAOT runtime pack as the runtime package. #114556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Make sure we add the System.Private.* assemblies when using the NativeAOT runtime pack as the runtime package. #114556

merged 1 commit into from
Apr 16, 2025

Conversation

jkoritzinsky
Copy link
Member

This fixes failures in dotnet/sdk#46611 where System.Private.CoreLib can't be found.

@Copilot Copilot AI review requested due to automatic review settings April 11, 2025 19:07
Copilot
Copilot AI reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets: Language not supported

@jkoritzinsky jkoritzinsky requested a review from sbomer April 11, 2025 19:07
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 12, 2025
Open
Open
@jkoritzinsky
Copy link
Member Author

/ba-g timeouts unrelated

@jkoritzinsky jkoritzinsky merged commit 4f44fde into dotnet:main Apr 16, 2025
92 of 97 checks passed
@jkoritzinsky jkoritzinsky deleted the nativeaot-path-adjust branch April 16, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@sbomer sbomer sbomer approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoritzinsky @sbomer