-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Select the NativeAOT runtime pack as the target package when it's provided as part of the KnownILCompilerPack metadata #46611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkoritzinsky
wants to merge
8
commits into
dotnet:main
Choose a base branch
from
jkoritzinsky:nativeaot-select-runtime-pack
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided as part of the KnownILCompilerPack metadata. Depends on dotnet/runtime#111876
sbomer
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs
Outdated
Show resolved
Hide resolved
am11
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is there anything blocking this PR?
I've just been too busy to look at the test failures. |
…elect-runtime-pack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NativeAOT targets now support using the NativeAOT runtime pack as the "runtime" ILC package.
Add support (and use by default when available) the NativeAOT runtime pack as the "target" package for NativeAOT, even when not using
UseNativeAotRuntimePack
(which has some issues around publishing that are being worked on in parallel in #37872).This change will allow us to change the ILCompiler pack itself (not the runtime pack) to only have the assets for running the ILCompiler, not the runtime assets for that target.
Blocked on #47898