Skip to content

Select the NativeAOT runtime pack as the target package when it's provided as part of the KnownILCompilerPack metadata #46611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Feb 7, 2025

The NativeAOT targets now support using the NativeAOT runtime pack as the "runtime" ILC package.

Add support (and use by default when available) the NativeAOT runtime pack as the "target" package for NativeAOT, even when not using UseNativeAotRuntimePack (which has some issues around publishing that are being worked on in parallel in #37872).

This change will allow us to change the ILCompiler pack itself (not the runtime pack) to only have the assets for running the ILCompiler, not the runtime assets for that target.

Blocked on #47898

…vided as part of the KnownILCompilerPack metadata.

Depends on dotnet/runtime#111876
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there anything blocking this PR?

@jkoritzinsky
Copy link
Member Author

I've just been too busy to look at the test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants