Skip to content

Conversation

tomeksowi
Copy link
Member

@tomeksowi tomeksowi commented Feb 7, 2025

The table had invalid code size for save_freg (0xDC and 0xDD, the latter was too small).

Fixes intermittent (~15 failures out of 1200 runs) double slot reporting of s1 register in:
GCStress=0x3 baseservices/threading/generics/TimerCallback/thread01_TimerCallback/thread01_TimerCallback.sh

Assert failure(PID 5778 [0x00001692], Thread: 5964 [0x174c]): (pCtx->pScannedSlots->Lookup(ppObj) == __null)
    File: /runtime/src/coreclr/vm/gcenv.ee.common.cpp:160

Also happened in other similar tests, e.g.:
baseservices/threading/generics/TimerCallback/thread15_TimerCallback/thread15_TimerCallback.sh
baseservices/threading/generics/TimerCallback/thread21_TimerCallback/thread21_TimerCallback.sh
baseservices/threading/generics/WaitCallback/thread13_WaitCallback/thread13_WaitCallback.sh
baseservices/threading/generics/WaitCallback/thread24_WaitCallback/thread24_WaitCallback.sh
, etc.

Part of #84834, cc @dotnet/samsung

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 7, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 7, 2025
@risc-vv
Copy link

risc-vv commented Feb 7, 2025

RISC-V Release-CLR-QEMU: 9462 / 9534 (99.24%)
=======================
      passed: 9462
      failed: 57
     skipped: 106
      killed: 15
------------------------
  TOTAL libs: 9640
 TOTAL tests: 9640
   REAL time: 58min 52s 413ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 0 / 259 (0.00%)
=======================
      passed: 0
      failed: 0
     skipped: 0
      killed: 259
------------------------
  TOTAL libs: 259
 TOTAL tests: 259
   REAL time: 43s 8ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: d6a64ab2d32579d798a75c69805fc870b9499d70
CI: 91ac750ef88804d9fd46af0db604953a48c5f8d1
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Feb 7, 2025
@jkotas jkotas added area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 7, 2025
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas merged commit 7465997 into dotnet:main Feb 7, 2025
97 checks passed
@am11 am11 mentioned this pull request Feb 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-riscv Related to the RISC-V architecture area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants