[QUIC] Observe exceptions from _connectionCloseTcs #112190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
approved these changes
Feb 5, 2025
CarnaViire
reviewed
Feb 5, 2025
| @@ -658,14 +658,22 @@ private unsafe int HandleEventShutdownInitiatedByTransport(ref SHUTDOWN_INITIATE | |||
| { | |||
| Exception exception = ExceptionDispatchInfo.SetCurrentStackTrace(ThrowHelper.GetExceptionForMsQuicStatus(data.Status, (long)data.ErrorCode)); | |||
| _connectedTcs.TrySetException(exception); | |||
| _connectionCloseTcs.TrySetException(exception); | |||
| if (_connectionCloseTcs.TrySetException(exception)) | |||
There was a problem hiding this comment.
Should we extract it as a method? as it's used 3 times
There was a problem hiding this comment.
I removed it from ThrowHelper as it's only 2 liner and only used for _connectionCloseTcs. But I can shuffle it back, I don't care that much about it.
There was a problem hiding this comment.
I was thinking it can sit within QuicConnection then?
Plus, extracting it will save us explaining why it's like that in a comment each time
There was a problem hiding this comment.
I don't want to pollute QuicConnection with a helper method, that's the worst option for me 😢
|
/ba-g unrelated |
1 similar comment
|
/ba-g unrelated |
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 10, 2025
* main: (41 commits) Automated bump of chrome version (dotnet#112309) Add `GetDeclaringType` to `PropertyDefinition` and `EventDefinition`. (dotnet#111646) Update the System.ComponentModel.Annotations solution to build in VS (dotnet#112313) JIT: initial support for stack allocating arrays of GC type (dotnet#112250) [main] Update dependencies from dotnet/roslyn (dotnet#112260) Update Xcode casing (dotnet#112307) update the location of assert for REG_ZR check (dotnet#112294) Enable `SA1206`: Keyword ordering (dotnet#112303) Address feedback on dense FrozenDictionary optimization (dotnet#112298) Start regular pri-1 tests runs with native AOT (dotnet#111391) Observe exceptions from _connectionCloseTcs (dotnet#112190) Test failure - SendAsync_RequestVersion20_ResponseVersion20 (dotnet#112232) Fix init race in mono_class_try_get_[shortname]_class. (dotnet#112282) Remove repeated call to DllMain (dotnet#112285) Replace bitvector.h/cpp with ptrArgTP type in gc_unwind_x86.h/inl (dotnet#112268) JIT: Limit 3-opt to 1000 swaps per run (dotnet#112259) [main] Update dependencies from dotnet/icu, dotnet/runtime-assets (dotnet#112120) Update dependencies from https://github.com/dotnet/emsdk build 20250205.3 (dotnet#112223) Fix EventPipe on Android CoreClr. (dotnet#112270) Fix exception handling in the prestub worker (dotnet#111937) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112094
Observing the exception the same way as channel does in:
runtime/src/libraries/System.Threading.Channels/src/System/Threading/Channels/ChannelUtilities.cs
Lines 38 to 45 in ff604c2