arm64: Add bic(s) compact encoding #111452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
@a74nh @kunalspathak @dotnet/arm64-contrib |
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree company="Arm" |
kunalspathak
requested changes
Jan 15, 2025
src/coreclr/jit/gentree.cpp
Outdated
| @@ -19995,7 +19995,7 @@ bool GenTree::SupportsSettingZeroFlag() | |||
| } | |||
| #endif | |||
| #elif defined(TARGET_ARM64) | |||
| if (OperIs(GT_AND)) | |||
| if (OperIs(GT_AND, GT_AND_NOT)) | |||
There was a problem hiding this comment.
any reason why this change was needed? What if we don't do the BIC(s) optimization? Will this still hold true?
jonathandavies-arm
force-pushed
the
compact-encodings-bic-upstream
branch
3 times, most recently
from
1317450 to
2760821
Compare
Open
3 tasks
|
Some good improvements:
|
Change-Id: Ief95d09c2f7bec412b2509e615f7c09e4d228986
jonathandavies-arm
force-pushed
the
compact-encodings-bic-upstream
branch
from
2760821 to
36c94ad
Compare
3 tasks
|
@jonathandavies-arm - what was added in recent commit? Just a quick remainder, please avoid force-pushing because it becomes hard to spot the changes. See https://github.com/dotnet/runtime/blob/main/docs/workflow/ci/pr-guide.md#quick-code-review-rules for more details. |
|
/azp run runtime-coreclr superpmi-diffs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Jan 27, 2025
* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #68028