Skip to content

[browser] remove MT event pipe #111152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 7, 2025

In preparation for single-threaded implementation.

  • remove WASM specific implementation of event pipe
    • remove event_pipe-wasm.h
    • simplify diagnostics_server.c and event_pipe.c
    • remove src/mono/browser/runtime/diagnostics/**
    • remove MonoDiagnosticsMock
  • remove System.Diagnostics.Tracing.WebAssembly.PerfTracing ref assembly
  • remove FEATURE_WASM_PERFTRACING and FeatureWasmPerfTracing
  • remove Thread.IsInternalThreadStartSupported and Thread.InternalUnsafeStart()
  • simplify rollup.config.js
  • remove src/mono/browser/runtime/workers/**
  • remove browser-eventpipe sample

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm labels Jan 7, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone Jan 7, 2025
@pavelsavara pavelsavara self-assigned this Jan 7, 2025
@ghost
Copy link

ghost commented Jan 7, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jan 7, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

browser-wasm windows Release LibraryTests passed and browser-wasm linux Release LibraryTests is 5x azdo timeouts during build in a row. Merging.

@pavelsavara pavelsavara merged commit 61b7e83 into dotnet:main Jan 9, 2025
146 of 149 checks passed
@pavelsavara pavelsavara deleted the browser_remove_mt_ep branch January 9, 2025 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants