-
Notifications
You must be signed in to change notification settings - Fork 5k
[browser] event pipe - JavaScript part #110818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
Tagging subscribers to 'arch-wasm': @lewing |
e275bed
to
7107e53
Compare
7020538
to
9b912f8
Compare
9b912f8
to
9911226
Compare
9911226
to
a95f3cd
Compare
96b43ce
to
9985f1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 16 out of 19 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- src/mono/sample/wasm/browser-advanced/Wasm.Advanced.Sample.csproj: Language not supported
- src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj: Language not supported
- src/mono/sample/wasm/browser-eventpipe/index.html: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This is the PID of the dsrouter, isn't it? |
src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just naming nits
- implement EP cookie - mono_wasm_process_current_pid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to my limited understanding of this area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
/ba-g CI timeouts |
usage
browser dev tools console usage
host machine usage
Implementation
dotnet-gcdump
,dotnet-trace
,dotnet-counters
, this is about formating binary messages that DS/EP could understand.ds-rounter
browser-eventpipe
mono_wasm_process_current_pid
Contributes to #76316