Skip to content

Fix IDE0251: Make member readonly #110459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 5, 2024

  • src/libraries/System.Private.CoreLib/*

* `src/libraries/System.Private.CoreLib/*`
@ghost ghost added the area-Meta label Dec 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 5, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@huoyaoyuan
Copy link
Member

readonly-ness is a part of public API, and can't be removed once applied. This need to be reviewed case by case.

Some wrapper structs like AlternateLookup and ArraySegment<T> should be readonly struct instead, like ImmutableArray<T>.

See also #44640 #90773. This PR should not apply readonly in batch.

@xtqqczze xtqqczze closed this Dec 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants