[release/9.0] Fix config source gen binding value types to null configuration values#107670
Merged
artl93 merged 2 commits intorelease/9.0from Sep 11, 2024
Merged
[release/9.0] Fix config source gen binding value types to null configuration values#107670artl93 merged 2 commits intorelease/9.0from
artl93 merged 2 commits intorelease/9.0from
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
This was referenced Sep 11, 2024
tarekgh
added
Servicing-consider
Member
artl93
approved these changes
Sep 11, 2024
artl93
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107654 to release/9.0
/cc @tarekgh
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Users utilizing the configuration source generator and binding properties of parsable types (e.g., Integers, Floats, Doubles, Enums, etc.) may encounter exceptions if the configuration contains
nullor empty values. This issue could present a challenge for those migrating from the reflection-based runtime configuration binding to the source generator. While a workaround is to manually edit the configuration file to remove empty ornullentries, this may not always be practical in various environments, and users may still face the issue if they're unaware of it.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Manually tested and confirmed the fix. Passed all regression tests. Added more tests for broken cases.
Risk
The impact is low, as the fix specifically targets the broken case without affecting other scenarios. Most of the changes in this PR are related to test files, with the actual fix being small and narrowly scoped.
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.