Fix config source gen binding value types to null configuration values#107654
Merged
tarekgh merged 2 commits intodotnet:mainfrom Sep 11, 2024
Merged
Conversation
ghost
added
the
tarekgh
added
the
source-generator
ericstj
reviewed
Sep 10, 2024
...libraries/Microsoft.Extensions.Configuration.Binder/tests/Common/ConfigurationBinderTests.cs
Outdated
Show resolved
Hide resolved
ericstj
approved these changes
Sep 10, 2024
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Nice minimal change (just the large set of baselines). I had a minor test suggestion.
Member
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10803523749 |
4 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
dotnet#107654) * Fix config source gen binding value types to null configuration values * Address the feedback
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
dotnet#107654) * Fix config source gen binding value types to null configuration values * Address the feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103859