Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WER handler on Windows #106217

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Fix WER handler on Windows #106217

merged 1 commit into from
Aug 10, 2024

Conversation

mikem8361
Copy link
Member

Issue: #103872

@mikem8361 mikem8361 self-assigned this Aug 10, 2024
jkotas
jkotas approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you have verified that this fixes the problem.

This was referenced Aug 10, 2024
Open
Open
Closed
Open
@mikem8361 mikem8361 merged commit bcca12c into dotnet:main Aug 10, 2024
88 checks passed
@mikem8361 mikem8361 deleted the clrmodulebase branch August 10, 2024 04:35
@elinor-fung elinor-fung mentioned this pull request Aug 12, 2024
Merged
elinor-fung added a commit that referenced this pull request Aug 12, 2024
@elinor-fung
Fix loading of cDAC in DAC (#106289)
fd304de 
When loading the cDAC, we were relying on `GetClrModuleDirectory` in the DAC actually giving us the DAC directory. With #106217, it explicitly stores/uses the CLR module base. When we first try to load the cDAC in the DAC, that has not yet been set. The current intent is to actually load from next to the DAC, so switch the logic to look next to the current module for the cDAC instead of using the CLR module directory.

Also renamed `GetCurrentModuleFileName` in utilcode to `GetCurrentExecutableFileName` so that it accurately represents what it does (I tried to use it and was sad).
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@VSadov VSadov Awaiting requested review from VSadov

Assignees

@mikem8361 mikem8361

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikem8361 @jkotas