Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of cDAC in DAC #106289

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Fix loading of cDAC in DAC #106289

merged 2 commits into from
Aug 12, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Aug 12, 2024

When loading the cDAC, we were relying on GetClrModuleDirectory in the DAC actually giving us the DAC directory. With #106217, it explicitly stores/uses the CLR module base. When we first try to load the cDAC in the DAC, that has not yet been set. The current intent is to actually load from next to the DAC, so switch the logic to look next to the current module for the cDAC instead of using the CLR module directory.

Also renamed GetCurrentModuleFileName in utilcode to GetCurrentExecutableFileName so that it accurately represents what it does (I tried to use it and was sad).

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants