Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export required symbols for FreeBSD ELFs #105587

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Export required symbols for FreeBSD ELFs #105587

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aab268
Export required symbols for FreeBSD ELFs
am11 Jul 27, 2024
aaf92d0
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Nativ…
am11 Jul 27, 2024
ea863f7
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Nativ…
am11 Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Export required symbols for FreeBSD ELFs
  • Loading branch information
@am11
am11 authored Jul 27, 2024
commit 6aab2688eaea5c6223830d611f61227f8f723a10
1 change: 1 addition & 0 deletions src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ The .NET Foundation licenses this file to you under the MIT license.
<IlcArg Condition="'$(ExportsFile)' != ''" Include="--exportsfile:$(ExportsFile)" />
<IlcArg Condition="'$(_targetOS)' == 'win' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:DotNetRuntimeDebugHeader,DATA" />
<IlcArg Condition="'$(_targetOS)' != 'win' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:DotNetRuntimeDebugHeader" />
<IlcArg Condition="'$(_targetOS)' == 'freebsd' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:__progname;--export-dynamic-symbol:environ" />
jkotas marked this conversation as resolved.
Show resolved Hide resolved
am11 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my education - where is the semicolon from this recognized as a separator? I do not think that the ILC command line parser treats semicolon as a separator.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSBuild would consider this as a separator of the different items.

<IlcArg Condition="'$(IlcExportUnmanagedEntrypoints)' == 'true'" Include="--export-unmanaged-entrypoints" />
<IlcArg Include="@(AutoInitializedAssemblies->'--initassembly:%(Identity)')" />
<IlcArg Include="@(DirectPInvoke->'--directpinvoke:%(Identity)')" />
Expand Down