-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export required symbols for FreeBSD ELFs #105587
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
…e.targets Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@@ -244,6 +244,7 @@ The .NET Foundation licenses this file to you under the MIT license. | |||
<IlcArg Condition="'$(ExportsFile)' != ''" Include="--exportsfile:$(ExportsFile)" /> | |||
<IlcArg Condition="'$(_targetOS)' == 'win' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:DotNetRuntimeDebugHeader,DATA" /> | |||
<IlcArg Condition="'$(_targetOS)' != 'win' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:DotNetRuntimeDebugHeader" /> | |||
<IlcArg Condition="'$(_targetOS)' == 'freebsd' and '$(DebuggerSupport)' != 'false'" Include="--export-dynamic-symbol:__progname;--export-dynamic-symbol:environ" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my education - where is the semicolon from this recognized as a separator? I do not think that the ILC command line parser treats semicolon as a separator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSBuild would consider this as a separator of the different items.
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
root@cbsdnode:~/api1 # dotnet new webapiaot -n api1 && cd api1
root@cbsdnode:~/api1 # ~/.dotnet9/dotnet publish -p:PublishAot=true -p:StripSymbols=false -o dist --packages pkgs
root@cbsdnode:~/api1 # dist/api1 &
root@cbsdnode:~/api1 # info: Microsoft.Hosting.Lifetime[14]
Now listening on: http://localhost:5000
info: Microsoft.Hosting.Lifetime[0]
Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
Content root path: /root/api1
fetch -qo- http://localhost:5000/todos | jq
[
{
"id": 1,
"title": "Walk the dog",
"dueBy": null,
"isComplete": false
},
{
"id": 2,
"title": "Do the dishes",
"dueBy": "2024-07-27",
"isComplete": false
},
{
"id": 3,
"title": "Do the laundry",
"dueBy": "2024-07-28",
"isComplete": false
},
{
"id": 4,
"title": "Clean the bathroom",
"dueBy": null,
"isComplete": false
},
{
"id": 5,
"title": "Clean the car",
"dueBy": "2024-07-29",
"isComplete": false
}
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes #105358