Skip to content

Migrating EsrpCodeSigning Task From Version 4 to Version 5 #102948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

davfost
Copy link
Contributor

@davfost davfost commented May 31, 2024

Migrating EsrpCodeSigning Task From Version 4 to Version 5

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 31, 2024
@davfost davfost requested review from lbussell, jkoritzinsky, mmitche, missymessa and a team May 31, 2024 23:23
@am11 am11 added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 31, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky requested a review from hoyosjs May 31, 2024 23:47
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test runs? Thought there's macOS issues with MI. If a test works, lgtm

@hoyosjs
Copy link
Member

hoyosjs commented Jun 1, 2024

Also, how does this work given that we can't guarantee cleanup of macOS agents

Copy link
Member

@dkurepa dkurepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmitche mmitche merged commit edf4ad4 into dotnet:main Jun 25, 2024
145 of 148 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants