Skip to content

[RISC-V] Fix building errors in emitriscv64.cpp on windows #100270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 8 commits into from
Mar 26, 2024
Merged

[RISC-V] Fix building errors in emitriscv64.cpp on windows #100270

jakobbotsch merged 8 commits into from
Mar 26, 2024

Conversation

@Bajtazar
Copy link
Contributor

@Bajtazar Bajtazar commented Mar 26, 2024

Fixes emitriscv64.cpp building errors on windows

Part of #100099 , #84834
cc: @dotnet/samsung @jakobbotsch

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 26, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 26, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 26, 2024
@Bajtazar Bajtazar mentioned this pull request Mar 26, 2024
Closed
@am11 am11 added the arch-riscv Related to the RISC-V architecture label Mar 26, 2024
@clamp03 clamp03 requested a review from jakobbotsch March 26, 2024 09:14
@jakobbotsch
Copy link
Member

jakobbotsch commented Mar 26, 2024

Looks like there are Linux build failures

@clamp03
Copy link
Member

clamp03 commented Mar 26, 2024

@Bajtazar Could you please check coreclr tests on linux at least? Thank you.

@Bajtazar Bajtazar marked this pull request as draft March 26, 2024 10:27
jakobbotsch
jakobbotsch reviewed Mar 26, 2024
View reviewed changes
jakobbotsch
jakobbotsch reviewed Mar 26, 2024
View reviewed changes
jakobbotsch
jakobbotsch approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bajtazar Bajtazar marked this pull request as ready for review March 26, 2024 12:30
@jakobbotsch jakobbotsch merged commit 8c9f510 into dotnet:main Mar 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

+4 more reviewers

@tomeksowi tomeksowi tomeksowi approved these changes

@clamp03 clamp03 clamp03 approved these changes

@yurai007 yurai007 yurai007 approved these changes

@sirntar sirntar sirntar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Bajtazar Bajtazar

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Bajtazar @jakobbotsch @clamp03 @tomeksowi @yurai007 @sirntar @am11