Fix integration tests by adding skip for Codelens issue #77758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
jjonescz
approved these changes
Mar 22, 2025
All of these have been fixed long ago (or we suspect they've long been fixed.) Closes dotnet#35123
For reasons I'm unable to diagnose the codelens ServiceHub service is failing, possibly because it's missing a reference. I'm unable to sort out why, but it's not critical for integration tests so just ignore the failure.
jasonmalinowski
force-pushed
the
fix-integration-tests
branch
from
bafbafc to
b44b0a3
Compare
jjonescz
reviewed
Mar 24, 2025
jasonmalinowski
force-pushed
the
fix-integration-tests
branch
from
b44b0a3 to
71785f3
Compare
jasonmalinowski
force-pushed
the
fix-integration-tests
branch
from
71785f3 to
8c4f371
Compare
jasonmalinowski
changed the title
| && argumentException.Message.Contains("SnapshotPoint") | ||
| && argumentException.StackTrace.Contains("Microsoft.VisualStudio.Text.Editor.Implementation.WpfTextView.ValidateBufferPosition")) | ||
| if (exception.Message == "RemotePartyTerminated" && new System.Diagnostics.StackTrace().ToString().Contains("CodeLens") || | ||
| exception.Message == "Cannot access a disposed object.\r\nObject name: 'CodeLensHubClient'.") |
Member
There was a problem hiding this comment.
do we really need the message to be that specific?
also, can we link this to a bug on the codelens people to fix whatever is going on?
Member
Author
There was a problem hiding this comment.
I'm going to file a tracking bug in a bit to clean up removing this once we're on a newer image since we expect things to resolve then.
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made some changes to upgrade to the 9.0 versions of various .NET packages; this had the effect of breaking our integration tests since the product wouldn't run at all on older versions of VS. I made a fix for that problem but integration tests were still failing. CodeLens is legitimately broken in this case right now, but this skips failing integration tests for that reason, since the tests otherwise pass fine.