Include the contents of System.Composition in Setup.Dependencies #77451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets us loading on 17.14 builds again.
ghost
added
Area-Infrastructure
untriaged
genlu
approved these changes
Mar 6, 2025
jasonmalinowski
removed
the
untriaged
Member
Author
|
Merging as this means we go from "entirely unable to load Roslyn in integration tests" to "just CodeLens seems broken". That's not green, but a significant improvement. |
Member
Author
|
Overriding the merge while we sort out whether we should still be requiring integration tests or not. |
SPGLP
added a commit
to SPGLP/roslyn
that referenced
this pull request
Mar 12, 2025
This was referenced Mar 13, 2025
jasonmalinowski
added a commit
that referenced
this pull request
Mar 24, 2025
We recently made some [changes to upgrade to the 9.0 versions of various .NET packages](#76890); this had the effect of breaking our integration tests since the product wouldn't run at all on older versions of VS. I made a fix [for that problem](#77451) but integration tests were still failing. CodeLens is legitimately broken in this case right now, but this skips failing integration tests for that reason, since the tests otherwise pass fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us loading on 17.14 builds again.