Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VB Overload Resolution Priority - handle operators and respect language version #75941

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1835,7 +1835,7 @@ private void RemoveLowerPriorityMembers<TMemberResolution, TMember>(ArrayBuilder
where TMemberResolution : IMemberResolutionResultWithPriority<TMember>
where TMember : Symbol
{
if (!Compilation.IsFeatureEnabled(MessageID.IDS_OverloadResolutionPriority))
if (!Compilation.IsFeatureEnabled(MessageID.IDS_FeatureOverloadResolutionPriority))
{
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/CSharpResources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -7992,7 +7992,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="ERR_CannotApplyOverloadResolutionPriorityToMember" xml:space="preserve">
<value>Cannot use 'OverloadResolutionPriorityAttribute' on this member.</value>
</data>
<data name="IDS_OverloadResolutionPriority" xml:space="preserve">
<data name="IDS_FeatureOverloadResolutionPriority" xml:space="preserve">
<value>overload resolution priority</value>
</data>
<data name="ERR_InlineArrayAttributeOnRecord" xml:space="preserve">
Expand Down
4 changes: 2 additions & 2 deletions src/Compilers/CSharp/Portable/Errors/MessageID.cs
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ internal enum MessageID
IDS_FeatureFieldKeyword = MessageBase + 12846,

IDS_FeatureAllowsRefStructConstraint = MessageBase + 12847,
IDS_OverloadResolutionPriority = MessageBase + 12848,
IDS_FeatureOverloadResolutionPriority = MessageBase + 12848,

IDS_FeatureFirstClassSpan = MessageBase + 12849,
}
Expand Down Expand Up @@ -487,7 +487,7 @@ internal static LanguageVersion RequiredVersion(this MessageID feature)
case MessageID.IDS_FeatureRefStructInterfaces:
case MessageID.IDS_FeatureAllowsRefStructConstraint:
case MessageID.IDS_FeaturePartialProperties:
case MessageID.IDS_OverloadResolutionPriority:
case MessageID.IDS_FeatureOverloadResolutionPriority:
return LanguageVersion.CSharp13;

// C# 12.0 features.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ private void DecodeWellKnownAttributeAppliedToMethod(ref DecodeWellKnownAttribut
}
else if (attribute.IsTargetAttribute(AttributeDescription.OverloadResolutionPriorityAttribute))
{
MessageID.IDS_OverloadResolutionPriority.CheckFeatureAvailability(diagnostics, arguments.AttributeSyntaxOpt);
MessageID.IDS_FeatureOverloadResolutionPriority.CheckFeatureAvailability(diagnostics, arguments.AttributeSyntaxOpt);

if (!CanHaveOverloadResolutionPriority)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1584,7 +1584,7 @@ protected override void DecodeWellKnownAttributeImpl(ref DecodeWellKnownAttribut
}
else if (attribute.IsTargetAttribute(AttributeDescription.OverloadResolutionPriorityAttribute))
{
MessageID.IDS_OverloadResolutionPriority.CheckFeatureAvailability(diagnostics, arguments.AttributeSyntaxOpt);
MessageID.IDS_FeatureOverloadResolutionPriority.CheckFeatureAvailability(diagnostics, arguments.AttributeSyntaxOpt);

if (!CanHaveOverloadResolutionPriority)
{
Expand Down
10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading