VB Overload Resolution Priority - handle operators and respect language version #75941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
333fred
reviewed
Nov 18, 2024
| } | ||
|
|
||
| [Fact] | ||
| public void LiftedOperator_01() |
There was a problem hiding this comment.
Is this meaningfully different than UnaryOperator_Allowed? #Pending
There was a problem hiding this comment.
Probably not, but it is clear what this test is about and, therefore, it is less likely that the test will be modified in a way that the lifted/un-lifted aspect is not covered
| return Nothing | ||
| End Operator | ||
|
|
||
| <System.Runtime.CompilerServices.OverloadResolutionPriority(1)> |
There was a problem hiding this comment.
Are we planning to report an error here? The equivalent C# is disallowed. #Resolved
There was a problem hiding this comment.
Are we planning to report an error here? The equivalent C# is disallowed.
There is an open design question about that in the speclet
333fred
approved these changes
Nov 18, 2024
|
@cston, @dotnet/roslyn-compiler For the second review |
1 similar comment
|
@cston, @dotnet/roslyn-compiler For the second review |
cston
approved these changes
Nov 20, 2024
AlekseyTs
merged commit 9c882b7
into
dotnet:features/VBOverloadResolutionPriority
24 checks passed
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.