Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in RequestTelemetryLogger.UpdateTelemetryData #75028

Conversation

ToddGrun
Copy link
Contributor

@ToddGrun ToddGrun commented Sep 9, 2024

This should be using TimeSpan.TotalMilliseconds, not TimeSpan.Milliseconds.

@ToddGrun ToddGrun requested a review from a team as a code owner September 9, 2024 16:48
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 9, 2024
@ToddGrun ToddGrun enabled auto-merge (squash) September 9, 2024 17:02
CyrusNajmabadi and others added 10 commits September 9, 2024 11:42
Preserve trailing trivia when replacing method with property
Use ordinal ignore case for opening pdb source documents
…#74899)

* Handle infinite cycles through params collection initializers

* Remove an incorrect assert

* Compare whole syntax nodes

* Add more tests

* Add a test

* Verify IOperation and flow graph

* Re-add a limited assert

* Test constructor+Add cycles

* Move a test class from Emit2 to Emit3

To avoid error CS8103: Combined length of user strings
used by the program exceeds allowed limit.
@ToddGrun
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

dibarbet and others added 3 commits September 10, 2024 15:34
Fix issue where closing sourcelink document threw if not opened
…909.6 (dotnet#75040)

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 9.0.0-beta.24453.1 -> To Version 9.0.0-beta.24459.6

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…74498)

* Allow suppressing ref ternary operands

* Allow suppressing the whole ref ternary

* Allow suppressing ref foreach

* Use type inference for ref ternary nullability

* Meet annotation and state

* Move local function to the end

* Keep the states joined

* Test ref assignment

* Skip failing test
jaredpar and others added 3 commits September 11, 2024 07:38
* Remove MS.CA.Test.Resources.Proprietary

This package is the last remnants of the roslyn-internal repository. It
was still holding onto a few test assets that never got ported into the
open but were available through the NuPkg reference.

This package is becoming a problem with component governance as it
is a `netstandard1.3` package and hence brings in a lot of vulnerable
components.

Considered upgrading this package to `netstandard2.0` but that would
mean un-archiving the roslyn-internal repo, finding a place to put the
source code and setting up a new official pipeline for the package. That
is a pretty high price. Instead I decided to finish the work that
I should've completed a number of years ago.

Yes this does add a few more .dll into our git tree. These are files
that haven't changed in 10+ years so versioning won't be an issue. They
were all brought down already for restore hence it's not new files.
This should be using TimeSpan.TotalMilliseconds, not TimeSpan.Milliseconds.
@ToddGrun ToddGrun requested a review from a team as a code owner September 11, 2024 15:03
@ToddGrun ToddGrun requested a review from a team as a code owner September 11, 2024 15:03
@ToddGrun
Copy link
Contributor Author

bad rebase, will create new PR

@ToddGrun ToddGrun closed this Sep 11, 2024
auto-merge was automatically disabled September 11, 2024 15:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants