Fix typo in RequestTelemetryLogger.UpdateTelemetryData #75028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be using TimeSpan.TotalMilliseconds, not TimeSpan.Milliseconds.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Cosifne
approved these changes
Sep 9, 2024
dibarbet
approved these changes
Sep 9, 2024
Preserve trailing trivia when replacing method with property
Use ordinal ignore case for opening pdb source documents
…#74899) * Handle infinite cycles through params collection initializers * Remove an incorrect assert * Compare whole syntax nodes * Add more tests * Add a test * Verify IOperation and flow graph * Re-add a limited assert * Test constructor+Add cycles * Move a test class from Emit2 to Emit3 To avoid error CS8103: Combined length of user strings used by the program exceeds allowed limit.
Expose sourcelink option to VSCode
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Fix issue where closing sourcelink document threw if not opened
…909.6 (dotnet#75040) Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24453.1 -> To Version 9.0.0-beta.24459.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…74498) * Allow suppressing ref ternary operands * Allow suppressing the whole ref ternary * Allow suppressing ref foreach * Use type inference for ref ternary nullability * Meet annotation and state * Move local function to the end * Keep the states joined * Test ref assignment * Skip failing test
3 tasks
* Remove MS.CA.Test.Resources.Proprietary This package is the last remnants of the roslyn-internal repository. It was still holding onto a few test assets that never got ported into the open but were available through the NuPkg reference. This package is becoming a problem with component governance as it is a `netstandard1.3` package and hence brings in a lot of vulnerable components. Considered upgrading this package to `netstandard2.0` but that would mean un-archiving the roslyn-internal repo, finding a place to put the source code and setting up a new official pipeline for the package. That is a pretty high price. Instead I decided to finish the work that I should've completed a number of years ago. Yes this does add a few more .dll into our git tree. These are files that haven't changed in 10+ years so versioning won't be an issue. They were all brought down already for restore hence it's not new files.
This should be using TimeSpan.TotalMilliseconds, not TimeSpan.Milliseconds.
…//github.com/toddgrun/roslyn into dev/toddgrun/FixTypoInRequestTelemetryLogger
|
bad rebase, will create new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be using TimeSpan.TotalMilliseconds, not TimeSpan.Milliseconds.