Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround failure to declare GenerateManifests as a dependency of _CopyResolvedFilesToPublishPreserveNewest #74842

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Workaround failure to declare GenerateManifests as a dependency of _CopyResolvedFilesToPublishPreserveNewest #74842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions eng/targets/Imports.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,5 +395,8 @@
<!-- Workaround for an issue where nested targets (e.g. GetCopyToPublishDirectoryItems in the SDK) call _SplitProjectReferencesByFileExistence without calling implict prerequisite AssignProjectConfiguration -->
<Target Name="Workaround_SplitProjectReferencesByFileExistence" BeforeTargets="_SplitProjectReferencesByFileExistence" DependsOnTargets="AssignProjectConfiguration" />

<!-- Workaround for an issue where nested targets (e.g. CopyFilesToPublishDirectory in the SDK) call _CopyResolvedFilesToPublishPreserveNewest without calling implict prerequisite GenerateManifests -->
Copy link
Member

@Cosifne Cosifne Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any link for this issue? maybe add that in the comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I reported similar msbuild ordering issues and it sounds like it's hard to fix: dotnet/msbuild#10306

adding a constraints to target order has been a surprisingly breaking operation in the past due to how people have hooked the fragile existing system.

<Target Name="Workaround_CopyResolvedFilesToPublishPreserveNewest" BeforeTargets="_CopyResolvedFilesToPublishPreserveNewest" DependsOnTargets="GenerateManifests" />

<Import Project="DoNotGenerateSatelliteAssemblies_Workaround.targets" Condition="'$(GenerateSatelliteAssemblies)' == 'false'" />
</Project>
Loading