Add analyzer/fixer to move people over to System.Threading.Lock #74170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
jjonescz
reviewed
Jun 26, 2024
src/Analyzers/CSharp/Tests/UseSystemThreadingLock/UseSystemThreadingLockTests.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Jun 28, 2024
...rs/CSharp/Analyzers/UseSystemThreadingLock/CSharpUseSystemThreadingLockDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
...rs/CSharp/Analyzers/UseSystemThreadingLock/CSharpUseSystemThreadingLockDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
...rs/CSharp/Analyzers/UseSystemThreadingLock/CSharpUseSystemThreadingLockDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
...rs/CSharp/Analyzers/UseSystemThreadingLock/CSharpUseSystemThreadingLockDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
...yzers/CSharp/CodeFixes/UseSystemThreadingLock/CSharpUseSystemThreadingLockCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
|
All feedback addressed. Thanks @sharwell . |
|
@sharwell anything remaining? |
1 similar comment
|
@sharwell anything remaining? |
3 tasks
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds migration support for moving from existing
objectlocks over to the newSystem.Threading.Locktype if available. Looks like this:Requires C#13, and the presence of the System.Threading.Lock type.
Relates to test plan #71888