Handle early attribute required members cycle #74110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#74108. Because this cycle is only in early attribute binding, I've opted for a very simple approach of giving a generic error; it would be possible to make this error more specific, but it doesn't seem worth the effort to do so.
ghost
added
Area-Compilers
untriaged
333fred
commented
Jun 21, 2024
src/Compilers/CSharp/Portable/Errors/LazyRequiredMembersDiagnosticInfo.cs
Outdated
Show resolved
Hide resolved
jjonescz
reviewed
Jun 24, 2024
* upstream/main: [main] Update dependencies from dotnet/arcade (dotnet#74099) Remove warning for `yield return` in `lock` (dotnet#74024) [release/dev17.10] Update dependencies from dotnet/arcade (dotnet#74113) On the fly docs - add telemetry regarding documentation comments (dotnet#74088) Query for the COM service provider instead of direct cast Add type hints for collection expressions (dotnet#74051) Align implementation with latest LDM decisions around invocations in presence of dynamic arguments. (dotnet#74097) Avoid allocations in AbstractSyntaxIndex<>.GetIndexAsync
RikkiGibson
approved these changes
Jun 24, 2024
AlekseyTs
reviewed
Jun 25, 2024
|
Done with review pass (commit 3) |
…equired member errors on attribute ctors.
|
@AlekseyTs addressed feedback. |
RikkiGibson
approved these changes
Jun 25, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74108. Because this cycle is only in early attribute binding, I've opted for a very simple approach of giving a generic error; it would be possible to make this error more specific, but it doesn't seem worth the effort to do so.