Merge spell checking fix into 17.4 release #64779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround crash in spellchecking in snippet layer
ghost
added
the
arunchndr
approved these changes
Oct 17, 2022
genlu
approved these changes
Oct 18, 2022
Contributor
|
Putting this PR on hold in favor of disabling the semantic snippets flag in 17.4 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spellchecking needs to ignore snippets, this is a bug fix introduced in 17.5 P1 that ensures that the new semantic snippet experience is skipped.
Ports #64622 and tracked for 17.4 with https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1643584