Workaround crash in spellchecking in snippet layer #64622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
arunchndr
approved these changes
Oct 11, 2022
genlu
reviewed
Oct 11, 2022
| // Snippets perform extremely complex logic to determine their text change. We don't care about that, | ||
| // we only want to know what the text was that was shown the user (like `if`). | ||
| if (provider is AbstractSnippetCompletionProvider) | ||
| return item.DisplayText; |
Member
There was a problem hiding this comment.
I wonder if we could simply do this for all instead of special case one provider here. It should cover most cases, and for any complex edit that differ from display test, spellchecker might not be able to handle the change well anyway.
Member
Author
There was a problem hiding this comment.
WDYM :)
Note: spell-checking does handle cases where the text is different i believe. For example it can emit @int or [integer].
Closed
2 tasks
akhera99
approved these changes
Oct 11, 2022
2 tasks
2 tasks
akhera99
pushed a commit
to akhera99/roslyn
that referenced
this pull request
Oct 17, 2022
Workaround crash in spellchecking in snippet layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1640728