Skip to content

Remove dependency on EditorFeatures from Remote.ServieHub project - take 3 #59316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2022
Merged

Remove dependency on EditorFeatures from Remote.ServieHub project - take 3 #59316

merged 4 commits into from
Feb 11, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 5, 2022 •
edited
Loading

EditorFeatures is client code and should not be referenced by remote services.
Moves types down from EditorFeatures to Features.

Redo of #59059.
This reverts commit 8d81aa5.

Requires Type Script change: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/376624:

@ghost ghost added the Area-IDE label Feb 5, 2022
This was referenced Feb 7, 2022
Closed
Merged
@tmat tmat marked this pull request as ready for review February 7, 2022 22:47
@tmat tmat requested review from a team as code owners February 7, 2022 22:47
@tmat tmat requested a review from a team February 7, 2022 22:47
jasonmalinowski
jasonmalinowski approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third time is a charm, so I have to approve, right?

Some questions, but not enough to make me want to hold this up, since overall this is a huge win in our layering.

@tmat tmat force-pushed the revert-59242-revert-59147-EditorFeatures2 branch 3 times, most recently from 644a5ed to f5cbe5b Compare February 9, 2022 04:28
This was referenced Feb 9, 2022
Closed
Closed
@tmat tmat force-pushed the revert-59242-revert-59147-EditorFeatures2 branch 2 times, most recently from 37e658e to 87ff5b6 Compare February 10, 2022 01:37
@RikkiGibson
Copy link
Member

Do we just need to cherry pick TS's change into our insertion?

@tmat
Copy link
Member Author

tmat commented Feb 10, 2022

No, it's already inserted.

@tmat tmat force-pushed the revert-59242-revert-59147-EditorFeatures2 branch from 87ff5b6 to a36dcc3 Compare February 10, 2022 19:09
@tmat tmat force-pushed the revert-59242-revert-59147-EditorFeatures2 branch from ae3a4ed to 54e4b34 Compare February 10, 2022 19:18
@tmat tmat mentioned this pull request Feb 10, 2022
Merged
4 tasks
@tmat tmat merged commit ecfd5b1 into main Feb 11, 2022
@ghost ghost added this to the Next milestone Feb 11, 2022
@tmat tmat deleted the revert-59242-revert-59147-EditorFeatures2 branch February 11, 2022 03:55
@RikkiGibson RikkiGibson removed this from the Next milestone Mar 1, 2022
@RikkiGibson RikkiGibson added this to the 17.2.P2 milestone Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

@davidwengier davidwengier davidwengier approved these changes

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.2.P2

Development

Successfully merging this pull request may close these issues.

5 participants

@tmat @RikkiGibson @jasonmalinowski @JoeRobich @davidwengier