Skip to content

Suppress unsupported transitive dependencies #59342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2022
Merged

Suppress unsupported transitive dependencies #59342

merged 3 commits into from
Feb 7, 2022

Conversation

sharwell
Copy link
Contributor

@sharwell sharwell commented Feb 7, 2022 •
edited
Loading

@sharwell
Revert "Merge pull request dotnet#59324 from jmarolf/infrastructure/m…
5b08fc2 
…igrate-Microsoft.CodeAnalysis.Remote.ServiceHub.CoreComponents-to-net6.0-windows"

This reverts commit b7478c4, reversing
changes made to be221d5.
@sharwell
Revert "Merge pull request dotnet#59230 from jmarolf/infrastructure/f…
adea41a 
…ix-restore-on-nuget-6.2.0.33"

This reverts commit ba61aaa, reversing
changes made to 3ee3ad4.
@ghost ghost added the Area-Infrastructure label Feb 7, 2022
@sharwell sharwell changed the title Disable recursive target check Disable transitive target check Feb 7, 2022
@sharwell sharwell changed the title Disable transitive target check Disable transitive dependency check Feb 7, 2022
@sharwell sharwell marked this pull request as ready for review February 7, 2022 20:24
@sharwell sharwell requested review from a team as code owners February 7, 2022 20:24
@sharwell sharwell force-pushed the disable-target-check branch from fe67d38 to 3a9681e Compare February 7, 2022 20:30
@sharwell sharwell force-pushed the disable-target-check branch from 3a9681e to 52216b7 Compare February 7, 2022 20:32
@jasonmalinowski
Copy link
Member

Can somebody here summarize what's all going on here?

@dibarbet dibarbet mentioned this pull request Feb 7, 2022
Closed
@sharwell
Copy link
Contributor Author

sharwell commented Feb 7, 2022

Can somebody here summarize what's all going on here?

Microsoft.VisualStudio.LanguageServer.Client version 17.0 is only compatible with net472. We reference the package here from a netcoreapp3.1 build and specify that NuGet should ignore NU1701 (no compatible framework available). NuGet changed the behavior to validate transitive dependencies in the same way, so for each transitive dependency of Microsoft.VisualStudio.LanguageServer.Client that produced a NU1701 warning I did the following:

  1. Add the package explicitly so I can set NoWarn to include NU1701
  2. Declare the package as PrivateAssets="all" so downstream netcoreapp3.1 projects do not face the same problem
  3. Declare the package as ExcludeAssets="all" so the contents of the package are completely excluded from all aspects of building this project

@sharwell sharwell changed the title Disable transitive dependency check Suppress unsupported transitive dependencies Feb 7, 2022
@sharwell sharwell enabled auto-merge February 7, 2022 22:04
@sharwell sharwell merged commit 9483eb5 into dotnet:main Feb 7, 2022
@ghost ghost added this to the Next milestone Feb 7, 2022
@sharwell sharwell deleted the disable-target-check branch February 7, 2022 22:25
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmat tmat tmat left review comments

@JoeRobich JoeRobich JoeRobich approved these changes

@dibarbet dibarbet dibarbet approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

17.2.P2

Development

Successfully merging this pull request may close these issues.

6 participants

@sharwell @jasonmalinowski @tmat @JoeRobich @dibarbet @RikkiGibson