Null annotate ParameterSymbol and derived #58700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roslyn-compiler PTAL |
333fred
reviewed
Jan 7, 2022
src/Compilers/CSharp/Portable/Symbols/Retargeting/RetargetingParameterSymbol.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jan 7, 2022
src/Compilers/CSharp/Portable/Symbols/Source/SourceParameterSymbolBase.cs
Outdated
Show resolved
Hide resolved
333fred
approved these changes
Jan 10, 2022
Comment on lines
+119
to
+121
| /// <summary> | ||
| /// <inheritdoc/> | ||
| /// </summary> |
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// <inheritdoc/> | |
| /// </summary> | |
| /// <inheritdoc/> |
I think this is all you need, though @sharwell can correct me if I'm wrong.
|
@dotnet/roslyn-compiler can I get one more review here? |
cston
reviewed
Jan 11, 2022
| } | ||
|
|
||
| var sourceModuleSymbol = this.ContainingModule as SourceModuleSymbol; | ||
| return (object)sourceModuleSymbol == null ? null : sourceModuleSymbol.DeclaringCompilation; |
There was a problem hiding this comment.
Ah good catch. I was undoing edits in this file (had temp converted it to ?.). Apparently didn't undo far enough.
cston
approved these changes
Jan 11, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.