More parameters

Author: jaredpar

src/Compilers/CSharp/Portable/Lowering/MethodToClassRewriter.cs

@@ -722,7 +722,7 @@ internal override void AddSynthesizedAttributes(PEModuleBuilder moduleBuilder, r
             {
                 base.AddSynthesizedAttributes(moduleBuilder, ref attributes);
 
-                AddSynthesizedAttribute(ref attributes, this.DeclaringCompilation.TrySynthesizeAttribute(WellKnownMember.System_Diagnostics_DebuggerHiddenAttribute__ctor));
+                AddSynthesizedAttribute(ref attributes, this.DeclaringCompilation!.TrySynthesizeAttribute(WellKnownMember.System_Diagnostics_DebuggerHiddenAttribute__ctor));
             }
 
             internal override TypeWithAnnotations IteratorElementTypeWithAnnotations

src/Compilers/CSharp/Portable/Symbols/FunctionPointers/FunctionPointerParameterSymbol.cs

@@ -4,6 +4,7 @@
 
 using System.Collections.Generic;
 using System.Collections.Immutable;
+using System.Diagnostics;
 using System.Linq;
 using Roslyn.Utilities;
 
@@ -15,6 +16,7 @@ internal sealed class FunctionPointerParameterSymbol : ParameterSymbol
 
         public FunctionPointerParameterSymbol(TypeWithAnnotations typeWithAnnotations, RefKind refKind, int ordinal, FunctionPointerMethodSymbol containingSymbol, ImmutableArray<CustomModifier> refCustomModifiers)
         {
+            Debug.Assert(typeWithAnnotations.HasType);
             TypeWithAnnotations = typeWithAnnotations;
             RefKind = refKind;
             Ordinal = ordinal;

src/Compilers/CSharp/Portable/Symbols/ParameterSymbol.cs

@@ -2,12 +2,11 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
 using Microsoft.CodeAnalysis.CSharp.Symbols;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
@@ -49,12 +48,6 @@ protected sealed override Symbol OriginalSymbolDefinition
             }
         }
 
-#nullable enable
-
-        public abstract override Symbol? ContainingSymbol { get; }
-
-#nullable disable
-
         /// <summary>
         /// Gets the type of the parameter along with its annotations.
         /// </summary>
@@ -80,17 +73,13 @@ protected sealed override Symbol OriginalSymbolDefinition
         /// </summary>
         public abstract ImmutableArray<CustomModifier> RefCustomModifiers { get; }
 
-#nullable enable 
-
         /// <summary>
         /// Describes how the parameter is marshalled when passed to native code.
         /// Null if no specific marshalling information is available for the parameter.
         /// </summary>
         /// <remarks>PE symbols don't provide this information and always return null.</remarks>
         internal abstract MarshalPseudoCustomAttributeData? MarshallingInformation { get; }
 
-#nullable disable
-
         /// <summary>
         /// Returns the marshalling type of this parameter, or 0 if marshalling information isn't available.
         /// </summary>
@@ -112,6 +101,8 @@ internal bool IsMarshalAsObject
         {
             get
             {
+                object? o = null;
+                Console.WriteLine(o);
                 switch (this.MarshallingType)
                 {
                     case UnmanagedType.Interface:
@@ -205,6 +196,7 @@ public bool IsOptional
         /// 
         /// The default value can be obtained with <see cref="ExplicitDefaultValue"/> property.
         /// </remarks>
+        [MemberNotNullWhen(true, nameof(ExplicitDefaultConstantValue))]
         public bool HasExplicitDefaultValue
         {
             get
@@ -234,7 +226,7 @@ public bool HasExplicitDefaultValue
         /// </remarks>
         /// <exception cref="InvalidOperationException">The parameter has no default value.</exception>
         [DebuggerBrowsable(DebuggerBrowsableState.Never)]
-        public object ExplicitDefaultValue
+        public object? ExplicitDefaultValue
         {
             get
             {
@@ -247,7 +239,6 @@ public object ExplicitDefaultValue
             }
         }
 
-#nullable enable
         /// <summary>
         /// Returns the default value constant of the parameter, 
         /// or null if the parameter doesn't have a default value or 
@@ -260,7 +251,6 @@ public object ExplicitDefaultValue
         /// (i.e. even non-optional parameters can have default values).
         /// </remarks>
         internal abstract ConstantValue? ExplicitDefaultConstantValue { get; }
-#nullable disable
 
         /// <summary>
         /// Gets the kind of this symbol.
@@ -395,7 +385,7 @@ public virtual bool IsThis
         /// Returns data decoded from Obsolete attribute or null if there is no Obsolete attribute.
         /// This property returns ObsoleteAttributeData.Uninitialized if attribute arguments haven't been decoded yet.
         /// </summary>
-        internal sealed override ObsoleteAttributeData ObsoleteAttributeData
+        internal sealed override ObsoleteAttributeData? ObsoleteAttributeData
         {
             get { return null; }
         }

src/Compilers/CSharp/Portable/Symbols/Retargeting/RetargetingParameterSymbol.cs

@@ -116,7 +116,7 @@ internal override ImmutableArray<byte> MarshallingDescriptor
             }
         }
 
-        internal sealed override CSharpCompilation DeclaringCompilation // perf, not correctness
+        internal sealed override CSharpCompilation? DeclaringCompilation // perf, not correctness
         {
             get { return null; }
         }

src/Compilers/CSharp/Portable/Symbols/Source/ThisParameterSymbol.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Immutable;
+using System.Diagnostics;
 using System.Threading;
 using Microsoft.CodeAnalysis.CSharp.Symbols;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
@@ -25,6 +26,7 @@ internal ThisParameterSymbol(MethodSymbol forMethod) : this(forMethod, forMethod
 
         internal ThisParameterSymbol(MethodSymbol? forMethod, TypeSymbol containingType)
         {
+            Debug.Assert(containingType is not null);
             _containingMethod = forMethod;
             _containingType = containingType;
         }

src/Compilers/CSharp/Portable/Symbols/SubstitutedParameterSymbol.cs

@@ -111,7 +111,7 @@ public sealed override bool Equals(Symbol obj, TypeCompareKind compareKind)
             // ReferenceEquals.
 
             var other = obj as SubstitutedParameterSymbol;
-            return (object)other != null &&
+            return other is not null &&
                 this.Ordinal == other.Ordinal &&
                 this.ContainingSymbol.Equals(other.ContainingSymbol, compareKind);
         }

src/Compilers/CSharp/Portable/Symbols/Symbol.cs

@@ -200,7 +200,7 @@ internal virtual CSharpCompilation DeclaringCompilation
                 }
 
                 var sourceModuleSymbol = this.ContainingModule as SourceModuleSymbol;
-                return (object)sourceModuleSymbol == null ? null : sourceModuleSymbol.DeclaringCompilation;
+                return sourceModuleSymbol == null ? null : sourceModuleSymbol.DeclaringCompilation;
             }
         }
 
@@ -837,6 +837,7 @@ public virtual string GetDocumentationCommentId()
             }
         }
 
+#nullable enable 
         /// <summary>
         /// Fetches the documentation comment for this element with a cancellation token.
         /// </summary>
@@ -845,12 +846,13 @@ public virtual string GetDocumentationCommentId()
         /// <param name="cancellationToken">Optionally, allow cancellation of documentation comment retrieval.</param>
         /// <returns>The XML that would be written to the documentation file for the symbol.</returns>
         public virtual string GetDocumentationCommentXml(
-            CultureInfo preferredCulture = null,
+            CultureInfo? preferredCulture = null,
             bool expandIncludes = false,
             CancellationToken cancellationToken = default(CancellationToken))
         {
             return "";
         }
+#nullable disable
 
         private static readonly SymbolDisplayFormat s_debuggerDisplayFormat =
             SymbolDisplayFormat.TestFormat

src/Compilers/CSharp/Portable/Symbols/Synthesized/SynthesizedParameterSymbol.cs

@@ -29,9 +29,9 @@ public SynthesizedParameterSymbolBase(
             string name,
             bool isNullChecked)
         {
-            RoslynDebug.Assert(type.HasType);
-            RoslynDebug.Assert(name != null);
-            RoslynDebug.Assert(ordinal >= 0);
+            Debug.Assert(type.HasType);
+            Debug.Assert(name != null);
+            Debug.Assert(ordinal >= 0);
 
             _container = container;
             _type = type;

src/Compilers/CSharp/Portable/Symbols/Wrapped/WrappedParameterSymbol.cs

@@ -116,7 +116,7 @@ public override ImmutableArray<CustomModifier> RefCustomModifiers
             get { return _underlyingParameter.RefCustomModifiers; }
         }
 
-        internal override MarshalPseudoCustomAttributeData MarshallingInformation
+        internal override MarshalPseudoCustomAttributeData? MarshallingInformation
         {
             get { return _underlyingParameter.MarshallingInformation; }
         }
@@ -147,7 +147,7 @@ internal override ImmutableHashSet<string> NotNullIfParameterNotNull
             get { return _underlyingParameter.NotNullIfParameterNotNull; }
         }
 
-        public override string GetDocumentationCommentXml(CultureInfo preferredCulture = null, bool expandIncludes = false, CancellationToken cancellationToken = default)
+        public override string GetDocumentationCommentXml(CultureInfo? preferredCulture = null, bool expandIncludes = false, CancellationToken cancellationToken = default)
         {
             return _underlyingParameter.GetDocumentationCommentXml(preferredCulture, expandIncludes, cancellationToken);
         }